Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8831

enforce_storage_engine doesn't block table creation on other nodes (galera cluster)

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 10.1.7
        • Fix Version/s: 10.1.8
        • Component/s: Galera
        • Environment:
          ubuntu server 15.04 64bits

          Description

          I set enforce_storage_engine to InnoDB and disable Myisam replication on all nodes of my cluster.

          When I try to create a Myisam table on a node, I logically get this error : Unknown storage engine 'MyISAM' and the table isn't created on this node.
          But it has been created on all other nodes! In the end, this table exists on every nodes of the cluster but one.

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                nirbhay_c Nirbhay Choubey added a comment -

                Patch attached.

                Show
                nirbhay_c Nirbhay Choubey added a comment - Patch attached.
                Hide
                Permalink
                jplindst Jan Lindström added a comment -

                Ok to push.

                Show
                jplindst Jan Lindström added a comment - Ok to push.
                Hide
                Permalink
                serg Sergei Golubchik added a comment -

                Nirbhay Choubey, why a failed CREATE TABLE statement is replicated at all?

                Show
                serg Sergei Golubchik added a comment - Nirbhay Choubey , why a failed CREATE TABLE statement is replicated at all?
                Hide
                Permalink
                nirbhay_c Nirbhay Choubey added a comment -

                Sergei Golubchik because, Galera replicates DDL during parsing (WSREP_TO_ISOLATION_BEGIN).

                Show
                nirbhay_c Nirbhay Choubey added a comment - Sergei Golubchik because, Galera replicates DDL during parsing (WSREP_TO_ISOLATION_BEGIN).
                Hide
                Permalink
                serg Sergei Golubchik added a comment -

                Nirbhay Choubey, and what happens if the table cannot be created? Like, table already exists, table exists in the InnoDB tablespace, unsupported combination of values for table options, whatever.

                Show
                serg Sergei Golubchik added a comment - Nirbhay Choubey , and what happens if the table cannot be created? Like, table already exists, table exists in the InnoDB tablespace, unsupported combination of values for table options, whatever.
                Hide
                Permalink
                nirbhay_c Nirbhay Choubey added a comment -

                Sergei Golubchik In that case, the DDL is expected to fail on all the nodes.

                Show
                nirbhay_c Nirbhay Choubey added a comment - Sergei Golubchik In that case, the DDL is expected to fail on all the nodes.
                Hide
                Permalink
                nirbhay_c Nirbhay Choubey added a comment -

                https://github.com/MariaDB/server/commit/38f3b99d469ab90f07287577d05e48928de720d4

                Show
                nirbhay_c Nirbhay Choubey added a comment - https://github.com/MariaDB/server/commit/38f3b99d469ab90f07287577d05e48928de720d4

                  People

                  • Assignee:
                    nirbhay_c Nirbhay Choubey
                    Reporter:
                    ronan Ronan GORAIN
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: