Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8576

Bootstrap should ignore --enforce-storage-engine option

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 10.1
        • Fix Version/s: 10.1.8
        • Component/s: OTHER
        • Labels:
          None
        • Sprint:
          10.1.8-2

          Description

          Currently if the server config file has enforce-storage-engine option, bootstrap would use it for system tables; but we are not ready for that yet, so it will fail badly.

            Gliffy Diagrams

              Attachments

                Issue Links

                blocks

                Bug - A problem which impairs or prevents the functions of the product. MDEV-8577 With enforce-storage-engine mysql_upgrade corrupts the schema: ALTER TABLE should either bypass enforce-storage-engine, or mysql_upgrade should refuse to run

                • Critical - Crashes, loss of data, severe memory leak.
                • Closed
                relates to

                Task - A task that needs to be done. MDEV-6858 enforce_storage_engine option

                • Major - Major loss of function.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  jplindst Jan Lindström added a comment -

                  http://lists.askmonty.org/pipermail/commits/2015-August/008240.html

                  Show
                  jplindst Jan Lindström added a comment - http://lists.askmonty.org/pipermail/commits/2015-August/008240.html
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  I don't think this needs any fixes in the server. mysql_install_db can disable enforce-storage-engine from the server's command line.
                  Okay, if enforce-storage-engine cannot be disabled, then it's a bug on itself that needs fixing, but that should be done anyway, unrelated to bootstrap. So, to sum it up, there should be two changes:

                  1. fix mysql_install_db to disable enforce-storage-engine from the server's command line.
                  2. (optionally) fix the server to allow enforce-storage-engine to be disabled.

                  It should be disabled either with --enforce-storage-engine="" or --disable-enforce-storage-engine or, may be, both should work.

                  Show
                  serg Sergei Golubchik added a comment - I don't think this needs any fixes in the server. mysql_install_db can disable enforce-storage-engine from the server's command line. Okay, if enforce-storage-engine cannot be disabled, then it's a bug on itself that needs fixing, but that should be done anyway, unrelated to bootstrap. So, to sum it up, there should be two changes: fix mysql_install_db to disable enforce-storage-engine from the server's command line. (optionally) fix the server to allow enforce-storage-engine to be disabled. It should be disabled either with --enforce-storage-engine="" or --disable-enforce-storage-engine or, may be, both should work.
                  Hide
                  Permalink
                  jplindst Jan Lindström added a comment -

                  http://lists.askmonty.org/pipermail/commits/2015-September/008402.html

                  Show
                  jplindst Jan Lindström added a comment - http://lists.askmonty.org/pipermail/commits/2015-September/008402.html
                  Hide
                  Permalink
                  jplindst Jan Lindström added a comment -

                  commit 173e48695031ef17c69957751539060a0df1d6c7
                  Author: Jan Lindström <jan.lindstrom@mariadb.com>
                  Date: Wed Sep 16 13:01:04 2015 +0300

                  MDEV-8576: Bootstrap should ignore --enforce-storage-engine option

                  Allow enforce-storage-engine="" option and use that on mysql_install_db
                  when doing bootstrap.

                  Show
                  jplindst Jan Lindström added a comment - commit 173e48695031ef17c69957751539060a0df1d6c7 Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Wed Sep 16 13:01:04 2015 +0300 MDEV-8576 : Bootstrap should ignore --enforce-storage-engine option Allow enforce-storage-engine="" option and use that on mysql_install_db when doing bootstrap.

                    People

                    • Assignee:
                      jplindst Jan Lindström
                      Reporter:
                      elenst Elena Stepanova
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      5 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - Not Specified
                        Not Specified
                        Remaining:
                        Remaining Estimate - 0 minutes
                        0m
                        Logged:
                        Time Spent - 4 hours, 5 minutes
                        4h 5m

                          Agile