Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8567

return-statement with a value, in function returning 'void'

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Trivial
        • Resolution: Not a Bug
        • Affects Version/s: 10.1.6
        • Fix Version/s: N/A
        • Component/s: Compiling
        • Labels:
          None

          Description

          /home/abuild/rpmbuild/BUILD/mariadb-10.1.6/sql/sql_plugin.cc:3623:12: error: return-statement with a value, in function returning 'void' [-fpermissive]
     return false;
            ^

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                serg Sergei Golubchik added a comment -

                It seems to me that it's an opensuse patch that adds "return 0", I don't see it in our code.
                And even your attached patch says "PATCH-P0-HACK-UPSTREAM: Silence compilator about no return".

                Show
                serg Sergei Golubchik added a comment - It seems to me that it's an opensuse patch that adds "return 0", I don't see it in our code. And even your attached patch says "PATCH-P0-HACK-UPSTREAM: Silence compilator about no return".
                Hide
                Permalink
                miska Michal Hrusecky added a comment -

                Ah, I'm terribly sorry, you are right, it was caused by patch that was fixing previous state but you fixed it in the upstream and I didn't noticed. Sorry for the noise, this is invalid.

                Show
                miska Michal Hrusecky added a comment - Ah, I'm terribly sorry, you are right, it was caused by patch that was fixing previous state but you fixed it in the upstream and I didn't noticed. Sorry for the noise, this is invalid.
                Hide
                Permalink
                serg Sergei Golubchik added a comment -

                Sure, no problem. Closing...

                Show
                serg Sergei Golubchik added a comment - Sure, no problem. Closing...

                  People

                  • Assignee:
                    serg Sergei Golubchik
                    Reporter:
                    miska Michal Hrusecky
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: