Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8546

Cleanup: remove st_plugin_int reference indirection

        Details

        • Type: Task
        • Status: Closed
        • Priority: Major
        • Resolution: Won't Fix
        • Fix Version/s: N/A
        • Component/s: Plugins
        • Labels:
          None
        • Sprint:
          10.1.8-1

          Description

          This is pure cleanup, no change in behavior.

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                svoj Sergey Vojtovich added a comment -

                Sergei Golubchik, please review patch for this task.

                Show
                svoj Sergey Vojtovich added a comment - Sergei Golubchik , please review patch for this task.
                Hide
                Permalink
                serg Sergei Golubchik added a comment -

                I don't think it's something worth fixing. It works, doesn't create any problems, really. I'd rather keep it.

                And it has that interesting property that plugin_lock() returns a pointer, and that pointer must be used when unlocking a plugin. This is very different from mutex locks, where you always lock and unlock the same (mutex) pointer.

                as usual, feel free to comment or reopen, if you disagree

                Show
                serg Sergei Golubchik added a comment - I don't think it's something worth fixing. It works, doesn't create any problems, really. I'd rather keep it. And it has that interesting property that plugin_lock() returns a pointer, and that pointer must be used when unlocking a plugin. This is very different from mutex locks, where you always lock and unlock the same (mutex) pointer. as usual, feel free to comment or reopen, if you disagree
                Hide
                Permalink
                svoj Sergey Vojtovich added a comment -

                At least a few times I had to spend extra hour or so to track down this code. So far I couldn't justify this indirection for myself.

                What's the value of this interesting property you're referring to?

                But since I'm alone here, let's keep it.

                Show
                svoj Sergey Vojtovich added a comment - At least a few times I had to spend extra hour or so to track down this code. So far I couldn't justify this indirection for myself. What's the value of this interesting property you're referring to? But since I'm alone here, let's keep it.

                  People

                  • Assignee:
                    serg Sergei Golubchik
                    Reporter:
                    svoj Sergey Vojtovich
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Agile