Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8376

Debian: build log scanner complains about some warnings

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 10.0
    • Fix Version/s: 10.0
    • Component/s: None
    • Labels:
      None

      Description

      The Debian build log scanner complains about some warnings it finds
      https://qa.debian.org/bls/packages/m/mariadb-10.0.html. Somebody should check into these and fix them in upstream code if possible.

      There're 3 distinct errors:

      • compiler-flags-hidden - this is probably false positive, double check when dpkg-buildflags-missing is fixed
      • dpkg-buildflags-missing - this one should be fixed in 10.1, see MDEV-5730
      • shlibs-symbol-not-found (missing symbol is __aeabi_atexit@CXXABI_ARM_1.3.3)

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            svoj Sergey Vojtovich added a comment -

            Sergei Golubchik, a warning referred as dpkg-buildflags-missing is about missing "-fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security". You added most of these flags in 10.1. Is it reasonable to backport it to 10.0?

            Otto Kekäläinen, if we consider this risky to backport to 10.0, you may have to add these flags to debian build scripts to fix this warning. compiler-flags-hidden is most probably false positive. But it is hard to say until dpkg-buildflags-missing is fixed.

            Show
            svoj Sergey Vojtovich added a comment - Sergei Golubchik , a warning referred as dpkg-buildflags-missing is about missing "-fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security". You added most of these flags in 10.1. Is it reasonable to backport it to 10.0? Otto Kekäläinen , if we consider this risky to backport to 10.0, you may have to add these flags to debian build scripts to fix this warning. compiler-flags-hidden is most probably false positive. But it is hard to say until dpkg-buildflags-missing is fixed.
            Hide
            svoj Sergey Vojtovich added a comment -

            shlibs-symbol-not-found happens on ARM, which I believe is not among of our supported platforms. I'd fix it anyway, but we have no ARM for debugging.

            Show
            svoj Sergey Vojtovich added a comment - shlibs-symbol-not-found happens on ARM, which I believe is not among of our supported platforms. I'd fix it anyway, but we have no ARM for debugging.
            Hide
            serg Sergei Golubchik added a comment -

            compiler-flags-hidden is false positive. Running blhc manually yields

            NONVERBOSE BUILD: [  7%] Building C object mysys/CMakeFiles/mysys.dir/my_open.c.o
            NONVERBOSE BUILD: [  7%] Building C object mysys/CMakeFiles/mysys.dir/my_pread.c.o
            

            This is, obviously, a blhc bug. Real compiler lines for these files come later in the log.

            Show
            serg Sergei Golubchik added a comment - compiler-flags-hidden is false positive. Running blhc manually yields NONVERBOSE BUILD: [ 7%] Building C object mysys/CMakeFiles/mysys.dir/my_open.c.o NONVERBOSE BUILD: [ 7%] Building C object mysys/CMakeFiles/mysys.dir/my_pread.c.o This is, obviously, a blhc bug. Real compiler lines for these files come later in the log.
            Hide
            serg Sergei Golubchik added a comment -

            dpkg-buildflags-missing looks like a packaging issue? Somehow Debian hardening flags aren't passed down to the compiler. Our cmake files certainly don't strip these flags away.

            Show
            serg Sergei Golubchik added a comment - dpkg-buildflags-missing looks like a packaging issue? Somehow Debian hardening flags aren't passed down to the compiler. Our cmake files certainly don't strip these flags away.
            Hide
            serg Sergei Golubchik added a comment - - edited

            shlibs-symbol-not-found looks suspiciously similar to a documented dpkg-shlibdeps bug. Quoting https://qa.debian.org/bls/bytag/W-shlibs-symbol-not-found.html

            Possible reasons:
            ...

            • a special symbol dpkg-shlibs had not yet in its blacklist.
              Currntly known is __aeabi_unwind_cpp_pr1@GCC_3.5, which can be ignored on armel and armhf.

            And we have the warning about __aeabi_atexit@CXXABI_ARM_1.3.3 on armel and armhf.

            Show
            serg Sergei Golubchik added a comment - - edited shlibs-symbol-not-found looks suspiciously similar to a documented dpkg-shlibdeps bug. Quoting https://qa.debian.org/bls/bytag/W-shlibs-symbol-not-found.html Possible reasons: ... a special symbol dpkg-shlibs had not yet in its blacklist. Currntly known is __aeabi_unwind_cpp_pr1@GCC_3.5 , which can be ignored on armel and armhf . And we have the warning about __aeabi_atexit@CXXABI_ARM_1.3.3 on armel and armhf .
            Hide
            serg Sergei Golubchik added a comment -

            Conclusion: these all are downstream (Debian) packaging issues, no upstream (MariaDB) changes are needed.

            Show
            serg Sergei Golubchik added a comment - Conclusion: these all are downstream (Debian) packaging issues, no upstream (MariaDB) changes are needed.

              People

              • Assignee:
                otto Otto Kekäläinen
                Reporter:
                svoj Sergey Vojtovich
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 20 minutes
                  20m