Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8219

enforce_storage_engine cannot be set globally

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.1.4
    • Fix Version/s: 10.1.6
    • Component/s: Admin statements
    • Labels:
      None
    • Sprint:
      10.1.6-1

      Description

      MariaDB [test]> set global enforce_storage_engine=MyISAM;
      ERROR 1228 (HY000): Variable 'enforce_storage_engine' is a SESSION variable and can't be used with SET GLOBAL
      

      I truly hope it's an oversight, although from the last comment to MDEV-6858, it seems it might have been done on purpose. It's understandable why a super-user should be able to overrule it sometimes on the session level, but the main goal of it is still being a server-wide rule.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              elenst Elena Stepanova added a comment - - edited

              I decreased the priority because it turned out it can be set as a server startup option (it was not obvious right away due to MDEV-8220).
              I still think it makes sense to allow it to be set globally, so I will keep it open; if there were really good reasons to prohibit it, please feel free to close as 'Won't fix'.

              Please also document it as a server option, currently it's not there: https://mariadb.com/kb/en/mariadb/full-list-of-mariadb-options-system-and-status-variables/

              Show
              elenst Elena Stepanova added a comment - - edited I decreased the priority because it turned out it can be set as a server startup option (it was not obvious right away due to MDEV-8220 ). I still think it makes sense to allow it to be set globally, so I will keep it open; if there were really good reasons to prohibit it, please feel free to close as 'Won't fix'. Please also document it as a server option , currently it's not there: https://mariadb.com/kb/en/mariadb/full-list-of-mariadb-options-system-and-status-variables/
              Hide
              jplindst Jan Lindström added a comment -

              This was intentional and now you can also use server option. What would be reasoning to be able to set it dynamically as server wide setting ?

              Show
              jplindst Jan Lindström added a comment - This was intentional and now you can also use server option. What would be reasoning to be able to set it dynamically as server wide setting ?
              Hide
              elenst Elena Stepanova added a comment -

              > What would be reasoning to be able to set it dynamically as server wide setting?

              Same as usual: changing (fixing) configuration without having to restart the server, it's important for many production setups, people tend to complain about not being able to change something at runtime. Generally, I expect a variable to be static only if making it dynamic causes potential troubles or makes the logic more complicated. If that's the case here, please by all means close it as "won't fix", otherwise maybe you'll re-consider.

              Show
              elenst Elena Stepanova added a comment - > What would be reasoning to be able to set it dynamically as server wide setting? Same as usual: changing (fixing) configuration without having to restart the server, it's important for many production setups, people tend to complain about not being able to change something at runtime. Generally, I expect a variable to be static only if making it dynamic causes potential troubles or makes the logic more complicated. If that's the case here, please by all means close it as "won't fix", otherwise maybe you'll re-consider.
              Show
              jplindst Jan Lindström added a comment - http://lists.askmonty.org/pipermail/commits/2015-June/008080.html
              Hide
              jplindst Jan Lindström added a comment -

              commit d535728165acb2eb55140bb70fa44c458d1ccc06
              Author: Jan Lindström <jan.lindstrom@mariadb.com>
              Date: Fri Jun 26 11:42:09 2015 +0300

              MDEV-8219: enforce_storage_engine cannot be set globally

              Change session only variable enforce_storage_engine to be
              session variable and make sure that also global value
              is used if session variable is not set.

              Show
              jplindst Jan Lindström added a comment - commit d535728165acb2eb55140bb70fa44c458d1ccc06 Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Fri Jun 26 11:42:09 2015 +0300 MDEV-8219 : enforce_storage_engine cannot be set globally Change session only variable enforce_storage_engine to be session variable and make sure that also global value is used if session variable is not set.

                People

                • Assignee:
                  jplindst Jan Lindström
                  Reporter:
                  elenst Elena Stepanova
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 1 day, 5 minutes
                    1d 5m

                      Agile