Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8122

REPAIR VIEW: FROM MYSQL should probably take precedence over mariadb-version

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 10.0, 5.5
    • Fix Version/s: N/A
    • Component/s: Admin statements
    • Labels:
      None
    • Sprint:
      5.5.45

      Description

      Currently REPAIR VIEW .. FROM MYSQL doesn't do anything of mariadb-version in the FRM file is already updated. It makes the extension fairly useless, because it means that to make it work, the user needs to prevent mysql_upgrade (including the automatic one), and also resist from running REPAIR VIEW... (without FROM MYSQL), which in real life will hardly even happen.

      But please only consider it if there is no risk breaking mysql_upgrade/mysqlcheck logic.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            serg Sergei Golubchik added a comment -

            I kind of agree with what you're saying. But on the other hand, I wouldn't want to turn REPAIR VIEW into a universal "alter view toggle algorithm" command.

            Show
            serg Sergei Golubchik added a comment - I kind of agree with what you're saying. But on the other hand, I wouldn't want to turn REPAIR VIEW into a universal "alter view toggle algorithm" command.
            Hide
            serg Sergei Golubchik added a comment -

            the user needs to prevent mysql_upgrade (including the automatic one)

            this is not quite true. mysql_upgrade will use REPAIR VIEW .. FROM MYSQL automatically, as needed. So normally the user does not need to do anything, only run mysql_upgrade (manually or automatically) after an upgrade.

            Show
            serg Sergei Golubchik added a comment - the user needs to prevent mysql_upgrade (including the automatic one) this is not quite true. mysql_upgrade will use REPAIR VIEW .. FROM MYSQL automatically, as needed. So normally the user does not need to do anything, only run mysql_upgrade (manually or automatically) after an upgrade.
            Hide
            serg Sergei Golubchik added a comment -

            Let's keep the current behavior. And later, if needed, we could either add FORCE variant or fix ALTER statement to be able to change view algorithm.

            Show
            serg Sergei Golubchik added a comment - Let's keep the current behavior. And later, if needed, we could either add FORCE variant or fix ALTER statement to be able to change view algorithm.

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                elenst Elena Stepanova
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Agile