Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8092

Change Create_field::field from "const char *" to LEX_CSTRING

        Details

        • Type: Task
        • Status: Open
        • Priority: Major
        • Resolution: Unresolved
        • Fix Version/s: 10.2
        • Component/s: None
        • Labels:
          None

          Description

          This is needed as a pre-requisite for a few other tasks.

          Note, under terms of this task we won't change Field::field_name in the same way. It still will be of type "const char *".
          That means that we'll have to use strlen(field->field_name) when creating a Create_field from a Field, in mysql_prepare_alter_table() create_table_from_items().
          But this is Okey for now, in long terms we'll change Field::field_name as well and get rid of strlen().

            Gliffy Diagrams

              Attachments

                Issue Links

                blocks

                Task - A task that needs to be done. MDEV-8093 sql_yacc.yy: add %type create_field for field_spec and column_def

                • Major - Major loss of function.
                • Open

                Task - A task that needs to be done. MDEV-8095 Split Create_field

                • Major - Major loss of function.
                • Open
                is blocked by

                Task - A task that needs to be done. MDEV-4912 Add a plugin to field types (column types)

                • Minor - Minor loss of function, or other problem where easy workaround is present.
                • In Progress

                  Activity

                  There are no comments yet on this issue.

                    People

                    • Assignee:
                      bar Alexander Barkov
                      Reporter:
                      bar Alexander Barkov
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated: