Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8032

[PATCH] audit plugin - csv output broken

        Details

        • Sprint:
          5.5.44

          Description

          since the audit file output is csv formatted, special characters like newline or tab should be replaced on the query. this replacement is done on querys with passwords (escape_string_hide_passwords) but not on casual escape_string()

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                h0nIg Hans-Joachim Kliemeck added a comment -

                created pull request https://github.com/MariaDB/server/pull/45

                Show
                h0nIg Hans-Joachim Kliemeck added a comment - created pull request https://github.com/MariaDB/server/pull/45
                Hide
                Permalink
                danblack Daniel Black added a comment -

                Could you add a test to mysql-test/suite/plugins/t/server_audit.test to cover this case?

                Show
                danblack Daniel Black added a comment - Could you add a test to mysql-test/suite/plugins/t/server_audit.test to cover this case?
                Hide
                Permalink
                holyfoot Alexey Botchkov added a comment -

                Thanks Hans-Joachim for noticing!
                fixing patch http://lists.askmonty.org/pipermail/commits/2015-June/008009.html

                Show
                holyfoot Alexey Botchkov added a comment - Thanks Hans-Joachim for noticing! fixing patch http://lists.askmonty.org/pipermail/commits/2015-June/008009.html

                  People

                  • Assignee:
                    holyfoot Alexey Botchkov
                    Reporter:
                    h0nIg Hans-Joachim Kliemeck
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0 minutes
                      0m
                      Logged:
                      Time Spent - 2 hours
                      2h

                        Agile