Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 10.1.7
    • Component/s: OTHER
    • Labels:
      None

      Description

      sql_alloc() has additional costs compared to direct mem_root allocation:

      • function call: it is defined in a separate translation unit and can't be inlined
      • it needs to call pthread_getspecific() to get THD::mem_root

      It is called dozens of times implicitly by Items. Try to get rid of those calls.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              svoj Sergey Vojtovich added a comment -

              Michael Widenius, please review attached patch.

              Show
              svoj Sergey Vojtovich added a comment - Michael Widenius , please review attached patch.
              Hide
              monty Michael Widenius added a comment -

              Review done per email. Please fix the very few issues and then ok to push

              Show
              monty Michael Widenius added a comment - Review done per email. Please fix the very few issues and then ok to push
              Hide
              monty Michael Widenius added a comment -

              See email

              Show
              monty Michael Widenius added a comment - See email

                People

                • Assignee:
                  svoj Sergey Vojtovich
                  Reporter:
                  svoj Sergey Vojtovich
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Agile