Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7977

[PATCH] MYSQL_BIN_LOG::write_incident failing to release LOCK_log

        Details

          Description

          sql/log.cc

          MYSQL_BIN_LOG::write_incident

  mysql_mutex_lock(&LOCK_log);
  if (likely(is_open()))
        ...
        mysql_mutex_unlock(&LOCK_log);
  }
  DBUG_RETURN(error);

          There is no mysql_mutex_unlock(LOCK_log) in the !likely(is_open()) if branch. It seems the caller of this function doesn't release it either.

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                danblack Daniel Black added a comment -

                https://github.com/MariaDB/server/pull/39

                Show
                danblack Daniel Black added a comment - https://github.com/MariaDB/server/pull/39
                Hide
                Permalink
                knielsen Kristian Nielsen added a comment -

                Pulled, thanks Daniel!

                Show
                knielsen Kristian Nielsen added a comment - Pulled, thanks Daniel!

                  People

                  • Assignee:
                    knielsen Kristian Nielsen
                    Reporter:
                    danblack Daniel Black
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: