Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7955

WSREP() appears on radar in OLTP RO

        Details

        • Type: Bug
        • Status: Open
        • Priority: Major
        • Resolution: Unresolved
        • Affects Version/s: 10.1
        • Fix Version/s: 10.1
        • Component/s: None
        • Labels:
          None

          Description

          Data comes from Sandy Bridge system running sysbench OLTP RO in 1 thread against 1 table.

          Time to time I can see WSREP() macro taking considerable amount of time. Since it is used quite frequently I'd suggest to optimize it a bit. Original macro is as following:

          #define WSREP_ON \
  (global_system_variables.wsrep_on)

#define WSREP(thd) \
  (WSREP_ON && wsrep && (thd && thd->variables.wsrep_on))
          • there should be no need to check "thd" - in most (if not all) cases it should be available
          • there should be no need to check "wsrep" - make sure it is set inline with wsrep_on
          • there should be no need to check "global_system_variables.wsrep_on"

          This leaves

          #define WSREP(thd) (thd)->variables.wsrep_on

            Gliffy Diagrams

              Attachments

                Activity

                There are no comments yet on this issue.

                  People

                  • Assignee:
                    nirbhay_c Nirbhay Choubey
                    Reporter:
                    svoj Sergey Vojtovich
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated: