Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7781

[PATCH] cannot install/uninstall plugins during bootstrap

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 10.0, 5.5
    • Fix Version/s: 10.0.18
    • Component/s: Plugins
    • Labels:

      Description

      As Otto Kekäläinen and I have been trying to package auth_socket.so install this plugin during install.

      As Jean and I noticed https://lists.launchpad.net/maria-developers/msg08317.html you can't install a plugin during bootstrap as it automaticly enables --skip-grant-tables (effectively).

      While you can insert into the plugin table directly this skips the init routes in the plugin, fine for auth_socket since it doesn't have any, however its a bad practice we probably don't want to encourage.

      patch: https://github.com/MariaDB/server/pull/29

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            serg Sergei Golubchik added a comment -

            If you INSERT directly into the plugin table, plugin is installed, but not loaded in memory. That is, is will be usable only after the server is restarted. Which is absolutely fine (and even desirable!) if you install a plugin for the user to use. But it's not fine if you install a plugin to use during bootstrap.

            Anyway, I agree that allowing INSTALL/UNINSTALL plugin with --skip-grants is ok.

            Show
            serg Sergei Golubchik added a comment - If you INSERT directly into the plugin table, plugin is installed, but not loaded in memory. That is, is will be usable only after the server is restarted. Which is absolutely fine (and even desirable!) if you install a plugin for the user to use. But it's not fine if you install a plugin to use during bootstrap. Anyway, I agree that allowing INSTALL/UNINSTALL plugin with --skip-grants is ok.

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                danblack Daniel Black
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m