Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-770

LP:695923 - Wrong recommendation for parameter log_slow_queries in warning during startup

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      When I start the database with:

      log_slow_queries = 0

      I get the following warning:

      101231  8:15:47 [Warning] '--log_slow_queries' is deprecated and will be removed in a future release. Please use ''--slow_query_log'/'--log-slow-file'' instead.
      

      This is a wrong recommendation. log-slow-file is deprecated as well and slow_query_log should be used instead.

         6393   {"log-slow-queries", OPT_SLOW_QUERY_LOG,
         6394     "Log slow queries to a table or log file. Defaults logging to table "
         6395     "mysql.slow_log or hostname-slow.log if --log-output=file is used. "
         6396     "Must be enabled to activate other slow log options. "
         6397     "(deprecated option, use --slow_query_log/--slow_query_log_file instead)",
         6398    &opt_slow_logname, &opt_slow_logname, 0, GET_STR, OPT_ARG,
         6399    0, 0, 0, 0, 0, 0},
      
         8757   case (int) OPT_SLOW_QUERY_LOG:
         8758     WARN_DEPRECATED(NULL, "7.0", "--log_slow_queries", "'--slow_query_log'/'--log-slow-file'");
         8759     opt_slow_log= 1;
         8760     break;
      

      It also looks like we have redundant code here!

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            shinguz shinguz added a comment -

            Fix for this bug report
            LPexportBug695923_patch_2.diff

            Show
            shinguz shinguz added a comment - Fix for this bug report LPexportBug695923_patch_2.diff
            Hide
            shinguz shinguz added a comment -

            Re: Wrong recommendation for parameter log_slow_queries in warning during startup

            Show
            shinguz shinguz added a comment - Re: Wrong recommendation for parameter log_slow_queries in warning during startup
            Hide
            ratzpo Rasmus Johansson added a comment -

            Launchpad bug id: 695923

            Show
            ratzpo Rasmus Johansson added a comment - Launchpad bug id: 695923
            Hide
            elenst Elena Stepanova added a comment -

            Not reproducible anymore, apparently it was fixed:

            [Warning] The syntax '-log-slow-queries' is deprecated and will be removed in a future release. Please use 'slow-query-log'/'-slow-query-log-file' instead.

            Show
            elenst Elena Stepanova added a comment - Not reproducible anymore, apparently it was fixed: [Warning] The syntax '- log-slow-queries' is deprecated and will be removed in a future release. Please use ' slow-query-log'/' -slow-query-log-file' instead.

              People

              • Assignee:
                Unassigned
                Reporter:
                shinguz shinguz
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: