Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7609

Improve error messaging when example_key_management_plugin is not preset

        Details

          Description

          Currently we only inform that key version is not found, but the actual reason is not.

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                jplindst Jan Lindström added a comment -

                Note that this fix changes plugin API for key_management_plugins/service

                Show
                jplindst Jan Lindström added a comment - Note that this fix changes plugin API for key_management_plugins/service
                Hide
                Permalink
                jplindst Jan Lindström added a comment -

                Not sure if this was the "best" way to do this, but at least it does work.

                Show
                jplindst Jan Lindström added a comment - Not sure if this was the "best" way to do this, but at least it does work.
                Hide
                Permalink
                serg Sergei Golubchik added a comment - - edited

                How relevant it is? The code is very different now, e.g. there is no fil_crypt_get_key() function anymore.

                Anyway, there is no need to introduce has_encryption_key_manager_func callback and change the API. You can check whether encryption key manager is loaded with encryption_key_id_exists(ENCRYPTION_KEY_SYSTEM_DATA). That key must always exist, if it doesn't — there is no encryption key manager.

                Show
                serg Sergei Golubchik added a comment - - edited How relevant it is? The code is very different now, e.g. there is no fil_crypt_get_key() function anymore. Anyway, there is no need to introduce has_encryption_key_manager_func callback and change the API. You can check whether encryption key manager is loaded with encryption_key_id_exists(ENCRYPTION_KEY_SYSTEM_DATA) . That key must always exist, if it doesn't — there is no encryption key manager.
                Hide
                Permalink
                jplindst Jan Lindström added a comment -

                Not relevant after MDEV-8764.

                Show
                jplindst Jan Lindström added a comment - Not relevant after MDEV-8764 .

                  People

                  • Assignee:
                    jplindst Jan Lindström
                    Reporter:
                    jplindst Jan Lindström
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0 minutes
                      0m
                      Logged:
                      Time Spent - 8 minutes
                      8m