Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7534

[PATCH] Fix TokuDB build on FreeBSD

        Details

          Description

          On FreeBSD, the cmake configuration currently skips TokuDB, as it only checks for a Linux x86_64 system. The attached patch fixes that and corrects a couple of other issues required to get Toku to build properly. I have been successfully using the resulting ha_tokudb.so plugin with MariaDB on FreeBSD 10.1 without issue.

          I have submitted these patches to the port maintainer also as a stopgap on FreeBSD until this is committed. See: <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197232>.

            Gliffy Diagrams

              Attachments

                Issue Links

                links to

                Web Link DB-816 [PATCH] Fix TokuDB build on FreeBSD

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  jhriggs Jim Riggs added a comment -

                  I would suspect that this might need to go upstream, but I have not checked.

                  Show
                  jhriggs Jim Riggs added a comment - I would suspect that this might need to go upstream, but I have not checked.
                  Hide
                  Permalink
                  elenst Elena Stepanova added a comment -

                  Hi,

                  Thanks for the patch.

                  Which version of MariaDB is it for – 5.5, 10.0, 10.1?
                  (On which one did you check the build?)

                  Show
                  elenst Elena Stepanova added a comment - Hi, Thanks for the patch. Which version of MariaDB is it for – 5.5, 10.0, 10.1? (On which one did you check the build?)
                  Hide
                  Permalink
                  jhriggs Jim Riggs added a comment -

                  Sorry. I actually thought about that this morning (that I hadn't mentioned the version). This was for 10.0.15 and 10.0.16.

                  And, it is worth noting that the build works on FreeBSD 10.0, not 10.1. 10.1 actually fails because of the new version of clang. :-\ So, we have been looking at the new issues caused by the new version of clang also. You can see the comments in the port bug report <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197232>.

                  Show
                  jhriggs Jim Riggs added a comment - Sorry. I actually thought about that this morning (that I hadn't mentioned the version). This was for 10.0.15 and 10.0.16. And, it is worth noting that the build works on FreeBSD 10.0, not 10.1. 10.1 actually fails because of the new version of clang. :-\ So, we have been looking at the new issues caused by the new version of clang also. You can see the comments in the port bug report < https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197232 >.
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  I've reported it to TokuDB's Jira: DB-816.

                  Show
                  serg Sergei Golubchik added a comment - I've reported it to TokuDB's Jira: DB-816 .

                    People

                    • Assignee:
                      serg Sergei Golubchik
                      Reporter:
                      jhriggs Jim Riggs
                    • Votes:
                      1 Vote for this issue
                      Watchers:
                      4 Start watching this issue

                      Dates

                      • Created:
                        Updated: