Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7504

tons of -Woverloaded-virtual warnings in CONNECT

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.0.16
    • Fix Version/s: 10.0.17
    • Labels:
      None

      Description

      In 10.0.16 after the 5.5 merge we've got -Woverloaded-virtual warning mode enabled. Connect engine produces lots of warnings of this kind.

      These warnings seem serious, better to have them fixed.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            bertrandop Olivier Bertrand added a comment -

            Sergei, could you send me a compilation log showing those warnings and explain to me what do they mean?
            Thanks.

            Show
            bertrandop Olivier Bertrand added a comment - Sergei, could you send me a compilation log showing those warnings and explain to me what do they mean? Thanks.
            Hide
            serg Sergei Golubchik added a comment -

            Sure, I've attached the log. The warning itself is pretty clear, but here's an explanation, just in case. Quoting gcc manual:

            ‘-Woverloaded-virtual (C++ and Objective-C++ only)’
            
                 Warn when a function declaration hides virtual functions from a
                 base class.  For example, in:
            
                      struct A {
                        virtual void f();
                      };
            
                      struct B: public A {
                        void f(int);
                      };
            
                 the ‘A’ class version of ‘f’ is hidden in ‘B’, and code like:
            
                      B* b;
                      b->f();
            
                 fails to compile.
            
            Show
            serg Sergei Golubchik added a comment - Sure, I've attached the log. The warning itself is pretty clear, but here's an explanation, just in case. Quoting gcc manual: ‘-Woverloaded-virtual (C++ and Objective-C++ only)’ Warn when a function declaration hides virtual functions from a base class. For example, in: struct A { virtual void f(); }; struct B: public A { void f(int); }; the ‘A’ class version of ‘f’ is hidden in ‘B’, and code like: B* b; b->f(); fails to compile.

              People

              • Assignee:
                bertrandop Olivier Bertrand
                Reporter:
                serg Sergei Golubchik
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours
                  4h