Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7477

Make innochecksum work with compressed tables

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.0.15
    • Fix Version/s: 10.0.16
    • Labels:
      None

      Description

      make innochecksum work on compressed tables

      this patch ports the work that facebook has performed
      to make innochecksum handle compressed tables.
      the basic idea is to use actual innodb-code to perform
      checksum verification rather than duplicating in innochecksum.cc.
      to make this work, innodb code has been annotated with
      lots of #ifndef UNIV_INNOCHECKSUM so that it can be
      compiled outside of storage/innobase.

      a new testcase is also added that verifies that innochecksum
      works on compressed/non-compressed tables.

      the actual steps to produce this patch are:

      • take innochecksum from 5.6.14
      • apply changes in innodb from facebook patches needed to make innochecksum compile
      • apply changes in innochecksum from facebook patches
      • add handcrafted testcase

      the referenced facebook patches used are:

          https://github.com/facebook/mysql-5.6/commit/91e25120e75272db4cdbc07d0e45877d9dea5715
          https://github.com/facebook/mysql-5.6/commit/847fe76ea5239b09fa361b023c56e6be76d32046
          https://github.com/facebook/mysql-5.6/commit/1135628a5a9b3412621b93233478f3804bcef51a
          https://github.com/facebook/mysql-5.6/commit/4dbf7c240ce2f08b7d6572d9452c9779ce90641c
      

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            jplindst Jan Lindström added a comment -

            Merging commig fabc79d2ea976c4ff5b79bfe913e6bc03ef69d42 from https://code.google.com/p/google-mysql/

            Show
            jplindst Jan Lindström added a comment - Merging commig fabc79d2ea976c4ff5b79bfe913e6bc03ef69d42 from https://code.google.com/p/google-mysql/
            Hide
            jplindst Jan Lindström added a comment -

            revno: 4564
            committer: Jan Lindström <jplindst@mariadb.org>
            branch nick: 10.0-innodb
            timestamp: Mon 2015-01-19 12:39:17 +0200
            message:
            MDEV-7477: Make innochecksum work on compressed tables

            Show
            jplindst Jan Lindström added a comment - revno: 4564 committer: Jan Lindström <jplindst@mariadb.org> branch nick: 10.0-innodb timestamp: Mon 2015-01-19 12:39:17 +0200 message: MDEV-7477 : Make innochecksum work on compressed tables

              People

              • Assignee:
                jplindst Jan Lindström
                Reporter:
                jplindst Jan Lindström
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: