Details
Trivial
Description
When compiling oqgraph in maria-5.2, GCC 4.4.4 reports the following warnings:
In file included from /usr/lib/gcc/i686-redhat-linux/4.4.4/../../../../include/c++/4.4.4/backward/hash_set:60,
from /usr/include/boost/graph/adjacency_list.hpp:25,
from graphcore.cc:40:
/usr/lib/gcc/i686-redhat-linux/4.4.4/../../../../include/c++/4.4.4/backward/backward_warning.h:28:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated.
In file included from graphcore.cc:41:
graphcore.cc: In function ‘void boost::breadth_first_visit(const IncidenceGraph&, typename boost::graph_traits<Graph>::vertex_descriptor, Buffer&, BFSVisitor, ColorMap) [with IncidenceGraph = boost::adjacency_list<boost::vecS, boost::vecS, boost::bidirectionalS, open_query::VertexInfo, open_query::EdgeInfo, boost::no_property, boost::listS>, Buffer = boost::queue<unsigned int, std::deque<unsigned int, std::allocator<unsigned int> > >, BFSVisitor = boost::bfs_visitor<std::pair<boost::predecessor_recorder<boost::iterator_property_map<__gnu_cxx::__normal_iterator<unsigned int*, std::vector<unsigned int, std::allocator<unsigned int> > >, boost::vec_adj_list_vertex_id_map<boost::property<boost::vertex_bundle_t, open_query::VertexInfo, boost::no_property>, unsigned int>, unsigned int, unsigned int&>, boost::on_tree_edge>, open_query::oqgraph_goal<false, boost::on_discover_vertex> > >, ColorMap = boost::two_bit_color_map<boost::vec_adj_list_vertex_id_map<boost::property<boost::vertex_bundle_t, open_query::VertexInfo, boost::no_property>, unsigned int> >]’:
graphcore.cc:208: warning: dereferencing pointer ‘p’ does break strict-aliasing rules
/usr/include/boost/optional/optional.hpp:593: note: initialized from here
graphcore.cc:208: warning: dereferencing pointer ‘p’ does break strict-aliasing rules
/usr/include/boost/optional/optional.hpp:593: note: initialized from here
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Re: Compiler warnings when compiling oqgraph in maria-5.2
The "missing initializer" are already fixed in the current 5.2
In storage/oqgraph/graphcore.cc line 52:
-static const row empty_row =
;
+static const row empty_row =
;
I get some of the other errors with gcc 4.3 (Ubuntu 10.04 Lucid).
The warnings appear to be related to the Boost Graph library which we don't directly control, as far as I can see there's nothing we can do about this, directly. Will assign to Antony to review.
Re: Compiler warnings when compiling oqgraph in maria-5.2
For any warnings in the Boost library, please file a bug in the upstream project. Our goal is to have a warning-free MariaDB.
Launchpad bug id: 645171
Re: Compiler warnings when compiling oqgraph in maria-5.2
Some more warnings:
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::orig_indicator’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::dest_indicator’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::weight_indicator’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::seq_indicator’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::link_indicator’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::latch’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::orig’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::dest’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::weight’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::seq’
graphcore.cc:52: warning: missing initializer for member ‘open_query::row::link’