Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 5.5.41
    • Fix Version/s: N/A
    • Component/s: Tests
    • Labels:
      None
    • Environment:
      Debian Wheezy 7.7

      Description

      Hello,

      How do you guys build the Debian Wheezy packages? Do you build them with DEB_BUILD_OPTIONS=nocheck to skip the tests or you have some magic environment different from an average Debian Wheezy installation?
      The package has been unbuildable since 5.5.35 (MDEV-5591 was never resolved in 5.5 branch). From 5.5.35 to 5.5.40 it could be fixed by removing the obsolete lines you removed from 10.0 (http://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/3975). But in 5.5.41 a change has been made to mysql-test/mysql-test-run.pl that is another non-starter to the test procedure.

      The tests kick of after changing "$basedir/extra/replace" to "$basedir/builddir/extra/replace" in the line 2497. It's kind of puzzling to me though how it is possible that the stock source packages for Debian Wheezy have been unbuildable since nearly a year and still you successfully build them. Am I missing something or doing something stupid while trying to build MariaDB 5.5.x from your stock Debian Wheezy source packages?

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              elenst Elena Stepanova added a comment -

              Yes, basically we build with nocheck, and we run all the tests separately on the installed packages (not as a part of the build process itself). You can see the logs here: http://buildbot.askmonty.org/buildbot/builders/kvm-deb-wheezy-amd64/builds/3175 .

              It makes us miss some problems which affect running tests on an out-of-source build.

              The debian expert, Otto Kekäläinen, builds in a more traditional fashion and reports problems to us (and solves many of them himself). You can seek his advice here or on #maria channel. MDEV-5591 was not fixed in 5.5 because it was agreed that we should incorporate Otto's changes instead.

              The problem you encountered is MDEV-7359, it will be fixed in the next release. As a workaround, Otto removed the new block which looks for the replace utility, you can try the same (apparently it was introduced in MySQL 5.5 to solve a problem on Windows, merged into MariaDB 5.5, but didn't get along with MariaDB's variation of MTR).

              Show
              elenst Elena Stepanova added a comment - Yes, basically we build with nocheck, and we run all the tests separately on the installed packages (not as a part of the build process itself). You can see the logs here: http://buildbot.askmonty.org/buildbot/builders/kvm-deb-wheezy-amd64/builds/3175 . It makes us miss some problems which affect running tests on an out-of-source build. The debian expert, Otto Kekäläinen , builds in a more traditional fashion and reports problems to us (and solves many of them himself). You can seek his advice here or on #maria channel. MDEV-5591 was not fixed in 5.5 because it was agreed that we should incorporate Otto's changes instead. The problem you encountered is MDEV-7359 , it will be fixed in the next release. As a workaround, Otto removed the new block which looks for the replace utility, you can try the same (apparently it was introduced in MySQL 5.5 to solve a problem on Windows, merged into MariaDB 5.5, but didn't get along with MariaDB's variation of MTR).
              Hide
              jorgus Szymon Juraszczyk added a comment -

              Thanks. I actually handle the problem the way I've described (the latest one by changing "$basedir/extra/replace" to "$basedir/builddir/extra/replace" in mysql-test/mysql-test-run.pl line 2497). I just thought some feedback might come in handy for you to make MariaDB even better and be able to build Debian packages with tests (which is the default) out of the box

              Show
              jorgus Szymon Juraszczyk added a comment - Thanks. I actually handle the problem the way I've described (the latest one by changing "$basedir/extra/replace" to "$basedir/builddir/extra/replace" in mysql-test/mysql-test-run.pl line 2497). I just thought some feedback might come in handy for you to make MariaDB even better and be able to build Debian packages with tests (which is the default) out of the box
              Hide
              elenst Elena Stepanova added a comment -

              Our build process uses debian/autobake-deb.sh which is, in fact, a documented recommended way to build deb packages https://mariadb.com/kb/en/mariadb/documentation/getting-started/compiling-mariadb-from-source/building-mariadb-on-ubuntu/ (the page is for Ubuntu, but still).

              While I agree that running the build with tests is technically a right thing to do, it would add even more burden on our already overloaded build system. We run tests on packages installed more or less the way a user would install them, and from an average user perspective it seems more important than running them upon a build. So, we would have to add build-time tests to post-installation tests, thus duplicating them. That's something we might not be able to afford.

              That said, we should definitely have at least one builder which would run tests on an out-of-source builds. Or rather two builders, Linux and Windows.

              The workaround with adding builddir can of course be only applied locally, it's not a generic solution.

              Show
              elenst Elena Stepanova added a comment - Our build process uses debian/autobake-deb.sh which is, in fact, a documented recommended way to build deb packages https://mariadb.com/kb/en/mariadb/documentation/getting-started/compiling-mariadb-from-source/building-mariadb-on-ubuntu/ (the page is for Ubuntu, but still). While I agree that running the build with tests is technically a right thing to do, it would add even more burden on our already overloaded build system. We run tests on packages installed more or less the way a user would install them, and from an average user perspective it seems more important than running them upon a build. So, we would have to add build-time tests to post-installation tests, thus duplicating them. That's something we might not be able to afford. That said, we should definitely have at least one builder which would run tests on an out-of-source builds. Or rather two builders, Linux and Windows. The workaround with adding builddir can of course be only applied locally, it's not a generic solution.
              Hide
              jorgus Szymon Juraszczyk added a comment -

              Don't worry, I can report you should any new problems with tests on Wheezy arise (there are already two) I need some customisations to the package so I build every new release myself. Running tests in such case is indeed desirable.

              Show
              jorgus Szymon Juraszczyk added a comment - Don't worry, I can report you should any new problems with tests on Wheezy arise (there are already two) I need some customisations to the package so I build every new release myself. Running tests in such case is indeed desirable.
              Hide
              elenst Elena Stepanova added a comment -

              Closing as a duplicate of MDEV-7359

              Show
              elenst Elena Stepanova added a comment - Closing as a duplicate of MDEV-7359

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  jorgus Szymon Juraszczyk
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: