Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-73

LP:912611 - ThreadPool does not print error messages even in case of critical problems

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.5.20
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      If something went really wrong with thread pool, e.g. it used up all threads (due to bad configuration) and further flow got locked up, we need to print meaningful error messages in the server error log. The messages should

      • be real errors – that is, not warnings, as warnings are often suppressed;
      • be printed in a reasonable manner, without flooding the error log;
      • identify problem as clearly as possible and maybe suggest further actions.

      Additional warnings might also make sense, for example if thread pool approaches max_threads. Same requirements about not flooding the error log apply to them, too.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            elenst Elena Stepanova added a comment -

            The bug is also filed in LP as https://bugs.launchpad.net/maria/+bug/912611

            Show
            elenst Elena Stepanova added a comment - The bug is also filed in LP as https://bugs.launchpad.net/maria/+bug/912611
            Hide
            wlad Vladislav Vaintroub added a comment -

            fixed in 5.5-threadpool. No warnings are printed yet, only real errors

            Show
            wlad Vladislav Vaintroub added a comment - fixed in 5.5-threadpool. No warnings are printed yet, only real errors

              People

              • Assignee:
                wlad Vladislav Vaintroub
                Reporter:
                elenst Elena Stepanova
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours
                  4h