Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7223

Iterator for LF_HASH

        Details

        • Type: Task
        • Status: Closed
        • Priority: Critical
        • Resolution: Fixed
        • Fix Version/s: 10.1.3
        • Component/s: Locking
        • Labels:
          None

          Description

          to be able to use LF_HASH in table definition cache and MDL cache, we need an iterator for LF_HASH

            Gliffy Diagrams

              Attachments

                Issue Links

                blocks

                Task - A task that needs to be done. MDEV-6089 MySQL WL#7305 "Improve MDL scalability by using lock-free hash"

                • Major - Major loss of function.
                • Closed
                links to

                Web Link Github revision #1

                Web Link Github revision #2

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  Pushed into bb-lf-iterator branch.
                  Sergey Vojtovich, please see if the new API is ok for you

                  Show
                  serg Sergei Golubchik added a comment - Pushed into bb-lf-iterator branch. Sergey Vojtovich , please see if the new API is ok for you
                  Hide
                  Permalink
                  svoj Sergey Vojtovich added a comment -

                  API as such is alright. I just hope this extra if won't be that expensive.

                  Show
                  svoj Sergey Vojtovich added a comment - API as such is alright. I just hope this extra if won't be that expensive.
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  Thanks. I hope not, it's inside unlikely() so in the normal use case it should be cheap. And I've removed one if in the previous changeset, which should compensate to an extent. Old if was actually worse — it was comparing volatile shared values and under high concurrency the expression could often return different results. New if expression uses only local variables and is false almost always.

                  Show
                  serg Sergei Golubchik added a comment - Thanks. I hope not, it's inside unlikely() so in the normal use case it should be cheap. And I've removed one if in the previous changeset, which should compensate to an extent. Old if was actually worse — it was comparing volatile shared values and under high concurrency the expression could often return different results. New if expression uses only local variables and is false almost always.
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  Sergey Vojtovich, please push it into 10.1 when and as you see fit. It's all your.

                  Show
                  serg Sergei Golubchik added a comment - Sergey Vojtovich , please push it into 10.1 when and as you see fit. It's all your.

                    People

                    • Assignee:
                      svoj Sergey Vojtovich
                      Reporter:
                      serg Sergei Golubchik
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - Not Specified
                        Not Specified
                        Remaining:
                        Remaining Estimate - 0 minutes
                        0m
                        Logged:
                        Time Spent - 1 day, 1 hour
                        1d 1h