Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7201

[PATCH] parallel threads resizing - potential race condition to access freed memory

        Details

          Description

          pool->threads is freed before being reassigned the new pool.

          Although not really a memory barrier I though it prudent to keep the pool thread count to be the lower of the old/new thread list before the new threads is allocated.

          Patch refers

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                knielsen Kristian Nielsen added a comment -

                Hm. As you say, due to no barriers this doesn't actually make any semantic
                change. But ok, if you think it makes the code clearer, it doesn't hurt
                anything, so I'll push it to 10.1.

                Show
                knielsen Kristian Nielsen added a comment - Hm. As you say, due to no barriers this doesn't actually make any semantic change. But ok, if you think it makes the code clearer, it doesn't hurt anything, so I'll push it to 10.1.
                Hide
                Permalink
                knielsen Kristian Nielsen added a comment -

                Pushed to 10.1.3

                Show
                knielsen Kristian Nielsen added a comment - Pushed to 10.1.3

                  People

                  • Assignee:
                    knielsen Kristian Nielsen
                    Reporter:
                    danblack Daniel Black
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: