Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7062

parser refactoring: don't store field properties in LEX

        Details

        • Type: Task
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Fix Version/s: 10.1.2
        • Component/s: Parser
        • Labels:
          None

          Description

          Currently when parsing a field definition all field properties are stored in LEX. LEX is kind of "everything and a kitchen sink" storage, it's way too large and lots of data that is there shouldn't be.

          This task is about removing field properties (that are used when parsing field definitions) from LEX and putting them into Create_field class directly

            Gliffy Diagrams

              Attachments

                Activity

                Hide
                Permalink
                serg Sergei Golubchik added a comment - - edited

                http://lists.askmonty.org/pipermail/commits/2014-November/006908.html

                From: serg@mariadb.org
To: commits@mariadb.org
Subject: [Commits] 2c904b9: parser cleanup: don't store field properties
         in LEX, use Create_field directly
Date: Mon, 10 Nov 2014 10:26:48 +0100

                Also the commit is in bb-10.1-serg tree. The idea is — to split Create_field::init in assignment and check phases. And do assignments directly in sql_yacc.yy, so Create_field::check (renamed ::init) will only do the check.

                Show
                serg Sergei Golubchik added a comment - - edited http://lists.askmonty.org/pipermail/commits/2014-November/006908.html From: serg@mariadb.org To: commits@mariadb.org Subject: [Commits] 2c904b9: parser cleanup: don't store field properties in LEX, use Create_field directly Date: Mon, 10 Nov 2014 10:26:48 +0100 Also the commit is in bb-10.1-serg tree. The idea is — to split Create_field::init in assignment and check phases. And do assignments directly in sql_yacc.yy , so Create_field::check (renamed ::init ) will only do the check.

                  People

                  • Assignee:
                    serg Sergei Golubchik
                    Reporter:
                    serg Sergei Golubchik
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: