Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 10.0.14
-
Fix Version/s: 10.0.15
-
Component/s: Storage Engine - Connect
-
Labels:
-
Environment:FreeBSD bobthebuilder 10.0-RELEASE-p7 FreeBSD 10.0-RELEASE-p7 #0: Tue Jul 8 06:37:44 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC
Description
When building MariaDB 10.0.14 using clang 3.3 on FreeBSD amd64, there's a compile error in storage/connect/filamap.h
107: virtual int GetNextPos(void)
{return (int)Fpos + Nrec;}error: cast from pointer to smaller type 'int' loses information
int is a 32-bit type this will not fit a memory address of a 64-bit platform. This should probably be handled using a uintptr_t type which should be available on all platforms.
Gliffy Diagrams
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Reopened until you tell me whether my last suggestions work with clang
Thanks for your guidance Olivier Please find revised patches attached, Mariadb-10.0.14 builds on FreeBSD 10.0 with these patches.
I applied the new patches successfully on Windows. However, on Linux the GCC compiling failed saying that uintptr_t was undeclared.
Therefore I added:
#include <stdint.h> // for uintprt_h
into the Unix declare section.
Is this ok with clang on FreeBSD?
Hi Olivier,
This is OK without adding an include for stdint.h anywhere in the storage/connect/ code
Built, packaged and deployed the server without a problem using the attached patches (sorry for the DOS CRLF)
This should fix all compiler issues. However, to do it in a cleaner way, I did not exactly apply the above patches:
In the InitDelete functions I changed the cast from uintptr_t to ptrdiff_t, which seems more appropriate and does not require including stdint.h.
About the array making, I have added an union in the PARM structure:
typedef struct _parm {
union {
void *Value;
int Intval;
}; // end union
short Type, Domain;
PPARM Next;
} PARM;
This makes possible to suppress all the funny casting that were done when creating the structure (in TXTFAM::AddListValue) and retrieving the integer value from it (in MakeValueArray)
Patches that enable build on FreeBSD 10.0 clang 3.3