Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6710

Embedded server fails to initialize if InnoDB plugin is used

    Details

      Description

      Embedded server is compiled withouth WITH_WSREP but InnoDB plugin with WITH_WSREP, this causes failure if dynamic InnoDB plugin is loaded on embedded server because of undefined symbols.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            jplindst Jan Lindström added a comment -

            Fix for embedded server.

            Show
            jplindst Jan Lindström added a comment - Fix for embedded server.
            Hide
            jplindst Jan Lindström added a comment -

            Could you please review at least server file changes diff attached on MDEV.

            Show
            jplindst Jan Lindström added a comment - Could you please review at least server file changes diff attached on MDEV.
            Hide
            nirbhay_c Nirbhay Choubey added a comment -

            IIUC, this can be resolved by having innodb plugin recompiled for 'embedded' with
            WITH_WSREP undef-ed. We currently do it for xtradb :

            MYSQL_ADD_PLUGIN(xtradb $

            {INNOBASE_SOURCES}

            STORAGE_ENGINE
            DEFAULT
            RECOMPILE_FOR_EMBEDDED
            LINK_LIBRARIES $

            {ZLIB_LIBRARY}

            $

            {LINKER_SCRIPT}

            )

            Show
            nirbhay_c Nirbhay Choubey added a comment - IIUC, this can be resolved by having innodb plugin recompiled for 'embedded' with WITH_WSREP undef-ed. We currently do it for xtradb : MYSQL_ADD_PLUGIN(xtradb $ {INNOBASE_SOURCES} STORAGE_ENGINE DEFAULT RECOMPILE_FOR_EMBEDDED LINK_LIBRARIES $ {ZLIB_LIBRARY} $ {LINKER_SCRIPT} )
            Hide
            jplindst Jan Lindström added a comment -

            True, but resulting shared library would not load to normal MariaDB server compiled by default using WITH_WSREP. I rather have one ha_innodb.so and those parts of server and/or tools that do not use galera add dummy variables/functions so that we can use the same ha_innodb.so as to normal MariaDB server.

            Show
            jplindst Jan Lindström added a comment - True, but resulting shared library would not load to normal MariaDB server compiled by default using WITH_WSREP. I rather have one ha_innodb.so and those parts of server and/or tools that do not use galera add dummy variables/functions so that we can use the same ha_innodb.so as to normal MariaDB server.
            Hide
            serg Sergei Golubchik added a comment -

            fixed and pushed in 10.1

            Show
            serg Sergei Golubchik added a comment - fixed and pushed in 10.1

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                jplindst Jan Lindström
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: