Details
Major
Description
Magic dependencies are a not a good thing.
If a library dependency is required, it should be checked for and error out if the system has it missing.
If it is optional, a cmake option should be made to skip over it if disabled, but error out if enabled and missing.
From a package manager's point of view, creating things that are optional if it simply exists becomes an issue if that library is ever removed from the system.
Please create options for each compression type if they are able to be disabled.
Suggestion for cmake option names: WITH_INNODB_{BZIP2,LZMA,LZO,LZ4}
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
commit 41dc186aa8a5340c78e783a635a95173cc46a697
Author: Jan Lindström <jan.lindstrom@skysql.com>
Date: Wed Feb 4 19:31:16 2015 +0200
MDEV-6633: Remove magic dependencies for InnoDB compression methods
Added options for each compression type that can be disabled i.e.
bzip2, lz4, lzma and lzo.
Sample patch from Gentoo for two of the options. This is used in our testing overlay before moving to the main tree.