Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6532

MySQL Bug#72544 - Incorrect locking for global_query_id

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 10.0.13
    • Component/s: None
    • Labels:
      None

      Description

      global_query_id is atomic variable. Though it is protected by mutex in sp_head.cc:

      mysql_mutex_lock(&LOCK_thread_count);
      q= global_query_id;
      mysql_mutex_unlock(&LOCK_thread_count);
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              svoj Sergey Vojtovich added a comment -

              Fixed by Monty in 10.0.13:

              revno: 4309
              revision-id: monty@mariadb.org-20140730185826-ixp284l6b2aoha2t
              parent: jplindst@mariadb.org-20140727054737-ieoohthuxc601q1a
              committer: Michael Widenius <monty@mariadb.org>
              branch nick: maria-10.0
              timestamp: Wed 2014-07-30 21:58:26 +0300
              message:
                Fixed wrong usage of global_query_id. (It's not protected by LOCK_thread_count)
              
              Show
              svoj Sergey Vojtovich added a comment - Fixed by Monty in 10.0.13: revno: 4309 revision-id: monty@mariadb.org-20140730185826-ixp284l6b2aoha2t parent: jplindst@mariadb.org-20140727054737-ieoohthuxc601q1a committer: Michael Widenius <monty@mariadb.org> branch nick: maria-10.0 timestamp: Wed 2014-07-30 21:58:26 +0300 message: Fixed wrong usage of global_query_id. (It's not protected by LOCK_thread_count)

                People

                • Assignee:
                  monty Michael Widenius
                  Reporter:
                  svoj Sergey Vojtovich
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: