Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6469

rpl.rpl_gtid_basic, rpl.rpl_gtid_stop_start, rpl.rpl_gtid_crash fail on PPC64

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 10.0.12
    • Fix Version/s: 10.0.13
    • Component/s: None
    • Labels:
      None

      Description

      See http://buildbot.askmonty.org/buildbot/builders/bintar-rhel6-p8/builds/231/steps/test/logs/stdio
      http://buildbot.askmonty.org/buildbot/builders/bintar-rhel6-p8-debug/builds/22/steps/test/logs/stdio

      CURRENT_TEST: rpl.rpl_gtid_basic
      --- /home/buildbot/maria-slave/power8-vlp01-debug/build/mysql-test/suite/rpl/r/rpl_gtid_basic.result	2014-07-22 04:13:09.328162000 -0400
      +++ /home/buildbot/maria-slave/power8-vlp01-debug/build/mysql-test/suite/rpl/r/rpl_gtid_basic.reject	2014-07-22 05:12:45.721614937 -0400
      @@ -185,14 +185,14 @@
       include/show_binlog_events.inc
       Log_name	Pos	Event_type	Server_id	End_log_pos	Info
       master-bin.000001	#	Format_desc	#	#	SERVER_VERSION, BINLOG_VERSION
      -master-bin.000001	#	Gtid_list	#	#	[1-2-20,0-1-10,0-3-30]
      +master-bin.000001	#	Gtid_list	#	#	[0-1-10,0-3-30,1-2-20]
       master-bin.000001	#	Binlog_checkpoint	#	#	master-bin.000001
       SELECT @@GLOBAL.gtid_binlog_pos;
       @@GLOBAL.gtid_binlog_pos
      -1-2-20,0-3-30
      +0-3-30,1-2-20
       SELECT @@GLOBAL.gtid_binlog_state;
       @@GLOBAL.gtid_binlog_state
      -1-2-20,0-1-10,0-3-30
      +0-1-10,0-3-30,1-2-20
       SET GLOBAL gtid_binlog_state = @old_state;
       ERROR HY000: This operation is not allowed if any GTID has been logged to the binary log. Run RESET MASTER first to erase the log
       RESET MASTER;
      @@ -252,7 +252,7 @@
       include/stop_slave.inc
       SET gtid_domain_id= 1;
       INSERT INTO t1 VALUES (3);
      -SET @pos= '1-1-1,0-1-110';
      +SET @pos= '0-1-110,1-1-1';
       SELECT master_gtid_wait(@pos, 0);
       master_gtid_wait(@pos, 0)
       -1
      

      GTID order in @@gtid_binlog_pos/state depend on internal hash order.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              svoj Sergey Vojtovich added a comment -

              Kristian, please review fix for this bug.

              The patch has been pushed to 10.0.13:

              revno: 4300
              revision-id: svoj@mariadb.org-20140722105438-2j4nv11k5xgdpi2u
              parent: jplindst@mariadb.org-20140722101716-ync0gxnwu25h18lu
              committer: Sergey Vojtovich <svoj@mariadb.org>
              branch nick: 10.0
              timestamp: Tue 2014-07-22 14:54:38 +0400
              message:
                MDEV-6469 - rpl.rpl_gtid_basic, rpl.rpl_gtid_stop_start,
                            rpl.rpl_gtid_crash fail on PPC64
                
                GTID order in @@gtid_binlog_pos depends on internal hash order,
                so requires to be hidden for stable test output.
              
              Show
              svoj Sergey Vojtovich added a comment - Kristian, please review fix for this bug. The patch has been pushed to 10.0.13: revno: 4300 revision-id: svoj@mariadb.org-20140722105438-2j4nv11k5xgdpi2u parent: jplindst@mariadb.org-20140722101716-ync0gxnwu25h18lu committer: Sergey Vojtovich <svoj@mariadb.org> branch nick: 10.0 timestamp: Tue 2014-07-22 14:54:38 +0400 message: MDEV-6469 - rpl.rpl_gtid_basic, rpl.rpl_gtid_stop_start, rpl.rpl_gtid_crash fail on PPC64 GTID order in @@gtid_binlog_pos depends on internal hash order, so requires to be hidden for stable test output.
              Hide
              monty Michael Widenius added a comment -

              patch ok, except one thing:
              in rpl_gtid_basic.result you removed the output of binary log

              Better to keep this and just replace the binlog_state with GTID_POS, similar as you do later in the file.

              Ie, replace:
              include/show_binlog_events.inc

              with something like:
              --replace_colum 2 #
              --replace "$pos" GTID_POS
              show binary logs;

              Show
              monty Michael Widenius added a comment - patch ok, except one thing: in rpl_gtid_basic.result you removed the output of binary log Better to keep this and just replace the binlog_state with GTID_POS, similar as you do later in the file. Ie, replace: include/show_binlog_events.inc with something like: --replace_colum 2 # --replace "$pos" GTID_POS show binary logs;
              Hide
              monty Michael Widenius added a comment -

              Ok to push after comments been taken care of

              Show
              monty Michael Widenius added a comment - Ok to push after comments been taken care of
              Hide
              svoj Sergey Vojtovich added a comment -

              Pushed additional patch to 10.0.13:

              revno: 4331
              revision-id: svoj@mariadb.org-20140806090716-qucnnzkxe1ds42cy
              parent: sergii@pisem.net-20140805163520-tz0w14h8uju0ti9n
              committer: Sergey Vojtovich <svoj@mariadb.org>
              branch nick: 10.0
              timestamp: Wed 2014-08-06 13:07:16 +0400
              message:
                MDEV-6469 - rpl.rpl_gtid_basic, rpl.rpl_gtid_stop_start,
                            rpl.rpl_gtid_crash fail on PPC64
                
                This is an addition to the original patch.
                
                Restored show binlog events output and adjusted filters to
                replace [\d-\d-\d,\d-\d-\d,\d-\d-\d] with [#-#-#].
              
              Show
              svoj Sergey Vojtovich added a comment - Pushed additional patch to 10.0.13: revno: 4331 revision-id: svoj@mariadb.org-20140806090716-qucnnzkxe1ds42cy parent: sergii@pisem.net-20140805163520-tz0w14h8uju0ti9n committer: Sergey Vojtovich <svoj@mariadb.org> branch nick: 10.0 timestamp: Wed 2014-08-06 13:07:16 +0400 message: MDEV-6469 - rpl.rpl_gtid_basic, rpl.rpl_gtid_stop_start, rpl.rpl_gtid_crash fail on PPC64 This is an addition to the original patch. Restored show binlog events output and adjusted filters to replace [\d-\d-\d,\d-\d-\d,\d-\d-\d] with [#-#-#].
              Hide
              monty Michael Widenius added a comment -

              Patch ok

              Show
              monty Michael Widenius added a comment - Patch ok

                People

                • Assignee:
                  svoj Sergey Vojtovich
                  Reporter:
                  svoj Sergey Vojtovich
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 10 minutes
                    10m