Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6350

Excessive unnecessary memory allocation at InnoDB/XtraDB startup if LZO is installed

    Details

      Description

      struct os_aio_slot_t{
      ...
      #ifdef HAVE_LZO
      	byte		lzo_mem[LZO1X_1_15_MEM_COMPRESS];
      #else
      	byte		lzo_mem[1];	/* Temporal memory used by LZO */
      #endif
      

      Modify array to be dynamically allocated and allocate if and only if LZO is really used.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            jplindst Jan Lindström added a comment -

            10.1

            commit 3bca01930aa5298cf6a8d602e66ddcea054edf50
            Author: Jan Lindström <jan.lindstrom@skysql.com>
            Date: Wed Jun 25 08:46:54 2014 +0300

            MDEV-6361: innodb_compression_algorithm configuration variable can
            be set to unsupported value.

            MDEV-6350: Excessive unnecessary memory allocation at InnoDB/XtraDB
            startup if LZO is installed.

            Show
            jplindst Jan Lindström added a comment - 10.1 commit 3bca01930aa5298cf6a8d602e66ddcea054edf50 Author: Jan Lindström <jan.lindstrom@skysql.com> Date: Wed Jun 25 08:46:54 2014 +0300 MDEV-6361 : innodb_compression_algorithm configuration variable can be set to unsupported value. MDEV-6350 : Excessive unnecessary memory allocation at InnoDB/XtraDB startup if LZO is installed.
            Hide
            jplindst Jan Lindström added a comment -

            10.0-FusionIO

            revno: 3988
            committer: Jan Lindström <jplindst@mariadb.org>
            branch nick: 10.0-FusionIO-release
            timestamp: Thu 2014-06-26 07:50:48 +0300
            message:
            MDEV-6361: innodb_compression_algorithm configuration variable can
            be set to unsupported value.

            MDEV-6350: Excessive unnecessary memory allocation at InnoDB/XtraDB
            startup if LZO is installed.

            MDEV-6376: InnoDB: Assertion failure in thread 139995225970432
            in file buf0mtflu.cc line 570.

            Show
            jplindst Jan Lindström added a comment - 10.0-FusionIO revno: 3988 committer: Jan Lindström <jplindst@mariadb.org> branch nick: 10.0-FusionIO-release timestamp: Thu 2014-06-26 07:50:48 +0300 message: MDEV-6361 : innodb_compression_algorithm configuration variable can be set to unsupported value. MDEV-6350 : Excessive unnecessary memory allocation at InnoDB/XtraDB startup if LZO is installed. MDEV-6376 : InnoDB: Assertion failure in thread 139995225970432 in file buf0mtflu.cc line 570.

              People

              • Assignee:
                jplindst Jan Lindström
                Reporter:
                jplindst Jan Lindström
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours
                  4h