Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6346

Implement Item::not_fixed_dec()

        Details

        • Type: Task
        • Status: Open
        • Priority: Minor
        • Resolution: Unresolved
        • Fix Version/s: 10.1
        • Component/s: None
        • Labels:
          None

          Description

          The fact that an Item has a not fixed number of decimal digits
          is currently stored in Item::decimals as a special value
          NOT_FIXED_DEC (31).

          We should stop using decimal==NOT_FIXED_DEC for that purposes,
          and introduce a new virtual method "bool not_fixed_dec()" instead.

          This should help to avoid bugs like this:
          https://mariadb.atlassian.net/browse/MDEV-4511
          when NOT_FIXED_DEC is erroneously treated as "normal"
          number of decimals.

          Also, there is currently no a way to get the real number of
          decimals from an Item if decimals=NOT_FIXED_DEC, which
          makes calculating decimal precision and scale hard in
          fix_length_and_dec() of some items.

            Gliffy Diagrams

              Attachments

                Activity

                There are no comments yet on this issue.

                  People

                  • Assignee:
                    bar Alexander Barkov
                    Reporter:
                    bar Alexander Barkov
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated: