Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6280

can't skip test with slash in its name

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.0.11
    • Fix Version/s: 10.0.12
    • Component/s: None
    • Labels:
      None

      Description

      Some of the tests from mysql-test have slash in their names (i. e. spider/bg.function). Such test can not be skipped with --skip-test-list, because line containing slash in the name of test is treated as "Syntax error".

      I am providing patch, which solves this issue.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            serg Sergei Golubchik added a comment -

            What did you do exactly to trigger this bug? I tried:

            10.0/mysql-test $ ./mtr --suite spider/bg --skip-test spider/bg.function
            Logging: ./mtr  --suite spider/bg --skip-test spider/bg.function
            vardir: /usr/home/serg/Abk/mysql/10.0/mysql-test/var
            Removing old var directory...
            Creating var directory '/usr/home/serg/Abk/mysql/10.0/mysql-test/var'...
            Checking supported features...
            MariaDB Version 10.0.11-MariaDB-debug
             - SSL connections supported
             - binaries are debug compiled
            Using suites: spider/bg
            Collecting tests...
            Installing system database...
            ==============================================================================
            TEST                                      RESULT   TIME (ms) or COMMENT
            --------------------------------------------------------------------------
            worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019
            spider/bg.function                       [ skipped ]
            spider/bg.spider3_fixes                  [ pass ]    554
            spider/bg.spider3_fixes_part             [ pass ]    532
            
            Show
            serg Sergei Golubchik added a comment - What did you do exactly to trigger this bug? I tried: 10.0/mysql-test $ ./mtr --suite spider/bg --skip-test spider/bg.function Logging: ./mtr --suite spider/bg --skip-test spider/bg.function vardir: /usr/home/serg/Abk/mysql/10.0/mysql-test/var Removing old var directory... Creating var directory '/usr/home/serg/Abk/mysql/10.0/mysql-test/var'... Checking supported features... MariaDB Version 10.0.11-MariaDB-debug - SSL connections supported - binaries are debug compiled Using suites: spider/bg Collecting tests... Installing system database... ============================================================================== TEST RESULT TIME (ms) or COMMENT -------------------------------------------------------------------------- worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019 spider/bg.function [ skipped ] spider/bg.spider3_fixes [ pass ] 554 spider/bg.spider3_fixes_part [ pass ] 532
            Hide
            jdornak Jakub Dorňák added a comment -

            This is one of many tests failing in Fedora rawhide (all architectures).
            We use --skip-test-list:

            perl ./mysql-test-run.pl --force --retry=0 --ssl \
                --skip-test-list=rh-skipped-tests.list \
                --suite-timeout=720 --testcase-timeout=30 \
                --mysqld=--binlog-format=mixed --force-restart \
                --shutdown-timeout=60 --max-test-fail=0
            
            Show
            jdornak Jakub Dorňák added a comment - This is one of many tests failing in Fedora rawhide (all architectures). We use --skip-test-list: perl ./mysql-test-run.pl --force --retry=0 --ssl \ --skip-test-list=rh-skipped-tests.list \ --suite-timeout=720 --testcase-timeout=30 \ --mysqld=--binlog-format=mixed --force-restart \ --shutdown-timeout=60 --max-test-fail=0
            Hide
            serg Sergei Golubchik added a comment -

            Ah, skip-test-list, not skip-test. Sorry. You're right, of course. Fixed.

            Show
            serg Sergei Golubchik added a comment - Ah, skip-test-list, not skip-test. Sorry. You're right, of course. Fixed.

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                jdornak Jakub Dorňák
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved: