Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6262

analyze the coverity report on mariadb

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: 10.0
    • Component/s: None
    • Labels:
      None

      Description

      See http://scan.coverity.com/projects/284?tab=Overview

      also, see how to make it scanned regularly

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              danblack Daniel Black added a comment -

              Seems to be possible if you do a travis_ci build https://scan.coverity.com/travis_ci

              Work in progress: https://github.com/openquery/mariadb-server/blob/travis-ci/.travis.yml

              build failures (that will hopefully turn successful) https://travis-ci.org/openquery/mariadb-server

              Show
              danblack Daniel Black added a comment - Seems to be possible if you do a travis_ci build https://scan.coverity.com/travis_ci Work in progress: https://github.com/openquery/mariadb-server/blob/travis-ci/.travis.yml build failures (that will hopefully turn successful) https://travis-ci.org/openquery/mariadb-server
              Hide
              danblack Daniel Black added a comment -

              currently waiting on https://github.com/travis-ci/travis-ci/issues/3729 / https://github.com/travis-ci/travis-ci/issues/3730

              After that adding a .travis.yml will get automated builds from build bot (need to login to travis-ci with the github login to enable this http://docs.travis-ci.com/user/getting-started/). The follow these instructions - https://scan.coverity.com/travis_ci for the CI part.

              As a bonus the github request that accumulate will have a run though the test suite before you think about looking at them.

              I'd suggest giving people with commit access some additional developer privs on the github account so they can close PRs or even merge simple changes directly.

              Show
              danblack Daniel Black added a comment - currently waiting on https://github.com/travis-ci/travis-ci/issues/3729 / https://github.com/travis-ci/travis-ci/issues/3730 After that adding a .travis.yml will get automated builds from build bot (need to login to travis-ci with the github login to enable this http://docs.travis-ci.com/user/getting-started/ ). The follow these instructions - https://scan.coverity.com/travis_ci for the CI part. As a bonus the github request that accumulate will have a run though the test suite before you think about looking at them. I'd suggest giving people with commit access some additional developer privs on the github account so they can close PRs or even merge simple changes directly.
              Hide
              serg Sergei Golubchik added a comment -

              I thought that people with commit access can do that already, can they not?

              Show
              serg Sergei Golubchik added a comment - I thought that people with commit access can do that already, can they not?
              Hide
              danblack Daniel Black added a comment -

              I thought that people with commit access can do that already, can they not?

              Seems so. I thought I was seeing a lot of pull requests closed by their originators, which was true, but most targeted a different branch to what was fixed, admitted to their own error, or it was patched differently or more completely.

              Progress report on travis-ci builds - going ok except for fairly frequent internal compile errors on ubuntu packaged gcc/g++ (4.9 and 5.1). e.g. https://travis-ci.org/openquery/mariadb-server/jobs/60365586 . I'll try to extract something meaningful to submit to the ubuntu toolchain team. Couple of other small issues however overall it seems a good way to get pull requests run though the test suite (with --big-tests), tested on gcc and clang, and if I can resolve the gcc/lcov compatibilty - code coverage on the service https://coveralls.io/r/openquery/mariadb-server . Feedback/questions welcome if you have time https://github.com/openquery/mariadb-server/blob/travis-ci-10.0/.travis.yml .

              Show
              danblack Daniel Black added a comment - I thought that people with commit access can do that already, can they not? Seems so. I thought I was seeing a lot of pull requests closed by their originators, which was true, but most targeted a different branch to what was fixed, admitted to their own error, or it was patched differently or more completely. Progress report on travis-ci builds - going ok except for fairly frequent internal compile errors on ubuntu packaged gcc/g++ (4.9 and 5.1). e.g. https://travis-ci.org/openquery/mariadb-server/jobs/60365586 . I'll try to extract something meaningful to submit to the ubuntu toolchain team. Couple of other small issues however overall it seems a good way to get pull requests run though the test suite (with --big-tests), tested on gcc and clang, and if I can resolve the gcc/lcov compatibilty - code coverage on the service https://coveralls.io/r/openquery/mariadb-server . Feedback/questions welcome if you have time https://github.com/openquery/mariadb-server/blob/travis-ci-10.0/.travis.yml .
              Hide
              danblack Daniel Black added a comment -

              Patch: https://github.com/MariaDB/server/pull/84

              Now that travis builds are container based with more memory they can occur fairly reliably: https://travis-ci.org/openquery/mariadb-server

              Uncommenting the coverity_scan addon in .travis.yml and adding the documented variables into the travis-ci web interface will run these scans on branches coverity_scan-.* allowing a flexible merge point for each major release.

              Show
              danblack Daniel Black added a comment - Patch: https://github.com/MariaDB/server/pull/84 Now that travis builds are container based with more memory they can occur fairly reliably: https://travis-ci.org/openquery/mariadb-server Uncommenting the coverity_scan addon in .travis.yml and adding the documented variables into the travis-ci web interface will run these scans on branches coverity_scan-.* allowing a flexible merge point for each major release.

                People

                • Assignee:
                  serg Sergei Golubchik
                  Reporter:
                  serg Sergei Golubchik
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:

                    Time Tracking

                    Estimated:
                    Original Estimate - 4 days
                    4d
                    Remaining:
                    Remaining Estimate - 4 days
                    4d
                    Logged:
                    Time Spent - Not Specified
                    Not Specified