Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6069

Remove old logic for 3.23-to-higher upgrades from upgrade SQL scripts

        Details

        • Type: Task
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Fix Version/s: 10.1.4
        • Component/s: OTHER
        • Labels:

          Description

          Scripts used for upgrade (e.g. mysql_system_tables_fix.sql) use ancient logic implemented for upgrades from very old versions, such as 3.23. It cannot stay there forever, the scripts grow complicated, and modification of them becomes error-prone. Since it is unrealistic to expect anyway, that live upgrade from such an old version would work, some clean-up is needed.

          See MDEV-6068 for an example of such logic.

          Also they can be simplified by using compound statements.

            Gliffy Diagrams

              Attachments

                Issue Links

                relates to

                Bug - A problem which impairs or prevents the functions of the product. MDEV-6068 Upgrade removes all changes to 'mysql' database

                • Critical - Crashes, loss of data, severe memory leak.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  nirbhay_c Nirbhay Choubey added a comment -

                  http://lists.askmonty.org/pipermail/commits/2014-December/007123.html

                  Show
                  nirbhay_c Nirbhay Choubey added a comment - http://lists.askmonty.org/pipermail/commits/2014-December/007123.html
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  I feel it's too radical. I still see questions about 5.1 every now and then.
                  Perhaps it's safer to remove only 3.23-5.0 code and keep upgrades from 5.1 and up?

                  Show
                  serg Sergei Golubchik added a comment - I feel it's too radical. I still see questions about 5.1 every now and then. Perhaps it's safer to remove only 3.23-5.0 code and keep upgrades from 5.1 and up?
                  Hide
                  Permalink
                  nirbhay_c Nirbhay Choubey added a comment -

                  Sure, I will modify the patch and recommit.

                  Show
                  nirbhay_c Nirbhay Choubey added a comment - Sure, I will modify the patch and recommit.
                  Hide
                  Permalink
                  nirbhay_c Nirbhay Choubey added a comment -

                  http://lists.askmonty.org/pipermail/commits/2015-March/007593.html

                  Show
                  nirbhay_c Nirbhay Choubey added a comment - http://lists.askmonty.org/pipermail/commits/2015-March/007593.html
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  ok to push

                  Show
                  serg Sergei Golubchik added a comment - ok to push
                  Hide
                  Permalink
                  nirbhay_c Nirbhay Choubey added a comment -

                  https://github.com/MariaDB/server/commit/5e6f12366abb02143ef57b6ff99285d81e3b3a36

                  Show
                  nirbhay_c Nirbhay Choubey added a comment - https://github.com/MariaDB/server/commit/5e6f12366abb02143ef57b6ff99285d81e3b3a36
                  Hide
                  Permalink
                  nirbhay_c Nirbhay Choubey added a comment -

                  Addendum : http://lists.askmonty.org/pipermail/commits/2015-March/007621.html

                  Show
                  nirbhay_c Nirbhay Choubey added a comment - Addendum : http://lists.askmonty.org/pipermail/commits/2015-March/007621.html
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  ok to push

                  Show
                  serg Sergei Golubchik added a comment - ok to push

                    People

                    • Assignee:
                      nirbhay_c Nirbhay Choubey
                      Reporter:
                      elenst Elena Stepanova
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      4 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - 1 day
                        1d
                        Remaining:
                        Remaining Estimate - 1 day
                        1d
                        Logged:
                        Time Spent - Not Specified
                        Not Specified