Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5906

Thread status not changed when applying log events

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.0.9
    • Fix Version/s: 10.0.11
    • Component/s: None
    • Labels:
      None

      Description

      The thread status of the SQL thread is not changed when it starts to apply a log event. The result is that the SQL thread has the status of "System lock" for the whole time it is executing relay log events.

      The status of the thread should be changed when it starts to execute an event.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            kolbe Kolbe Kegel added a comment -
             +++ sql/log_event.cc    2014-03-19 19:24:26 +0000
             @@ -9622,6 +9622,7 @@ int Rows_log_event::do_apply_event(rpl_g
                    goto err;
                  }
            
             +    THD_STAGE_INFO(thd, stage_executing);
                  /*
            
            Show
            kolbe Kolbe Kegel added a comment - +++ sql/log_event.cc 2014-03-19 19:24:26 +0000 @@ -9622,6 +9622,7 @@ int Rows_log_event::do_apply_event(rpl_g goto err; } + THD_STAGE_INFO(thd, stage_executing); /*
            Hide
            kolbe Kolbe Kegel added a comment - - edited

            That first patch Monty proposed didn't do it, but this other one he proposed does:

            +++ sql/log_event.cc    2014-03-20 16:59:38.112399862 +0000
            @@ -11183,6 +11183,7 @@ int Rows_log_event::do_apply_event(Relay
                     break;
                 }
            
            +    THD_STAGE_INFO(thd, stage_executing);
                 do {
            
                   error= (this->*do_apply_row_ptr)(rli);
            
            Show
            kolbe Kolbe Kegel added a comment - - edited That first patch Monty proposed didn't do it, but this other one he proposed does: +++ sql/log_event.cc 2014-03-20 16:59:38.112399862 +0000 @@ -11183,6 +11183,7 @@ int Rows_log_event::do_apply_event(Relay break; } + THD_STAGE_INFO(thd, stage_executing); do { error= (this->*do_apply_row_ptr)(rli);
            Hide
            monty Michael Widenius added a comment -

            Fixed.

            Show
            monty Michael Widenius added a comment - Fixed.

              People

              • Assignee:
                monty Michael Widenius
                Reporter:
                kolbe Kolbe Kegel
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: