Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5864

Reduce usage of LOCK_open: TABLE_SHARE::tdc.free_tables

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 10.0.9
        • Fix Version/s: 10.0.10
        • Component/s: None
        • Labels:
          None

          Description

          tc_acquire_table and tc_release_table are critical sections of table cache. Among other things, they update TABLE_SHARE::tdc.free_tables:
          tc_acquire_table - pop TABLE object from free_tables
          tc_release_table - push TABLE object to free_tables

          Updating free_tables list is protected by global mutex. Since free_tables is per-share list we can protect it by per-share mutex instead.

          This is simple intermediate change that improves table cache scalability in many loads.

            Gliffy Diagrams

              Attachments

                Issue Links

                relates to

                Bug - A problem which impairs or prevents the functions of the product. MDEV-7292 Table_open_cache scalability issues

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-4702 Reduce usage of LOCK_open

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-4956 Reduce usage of LOCK_open: TABLE_SHARE::tdc.used_tables

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-5388 Reduce usage of LOCK_open: unused_tables

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-5403 Reduce usage of LOCK_open: tc_count

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-5492 Reduce usage of LOCK_open: TABLE::in_use

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-5597 Reduce usage of LOCK_open: LOCK_flush

                • Major - Major loss of function.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  svoj Sergey Vojtovich added a comment -

                  Sergei, please review patch for this task.

                  Show
                  svoj Sergey Vojtovich added a comment - Sergei, please review patch for this task.
                  Hide
                  Permalink
                  svoj Sergey Vojtovich added a comment -

                  Fixed in 10.0.10, revno: 4071, revision-id: svoj@mariadb.org-20140320071113-ql1nx7dc9h22odx3

                  Show
                  svoj Sergey Vojtovich added a comment - Fixed in 10.0.10, revno: 4071, revision-id: svoj@mariadb.org-20140320071113-ql1nx7dc9h22odx3

                    People

                    • Assignee:
                      svoj Sergey Vojtovich
                      Reporter:
                      svoj Sergey Vojtovich
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - Not Specified
                        Not Specified
                        Remaining:
                        Remaining Estimate - 0 minutes
                        0m
                        Logged:
                        Time Spent - 2 hours, 30 minutes
                        2h 30m