Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-581

LP:929838 - Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests

    Details

    • Type: Bug
    • Status: Stalled
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 5.3.12, 5.5
    • Fix Version/s: 5.3.13, 5.5
    • Component/s: None
    • Labels:

      Description

      After downport of InnoDB/ICP from mysql 5.6 (revno: 2955) the number of Innodb_buffer_pool_read_requests made by the sample query has increased.

      Fixed made by
      revno: 3406 revision-id: <email address hidden>
      revno: 3407 revision-id: <email address hidden>

      address the problem for the most part, but certain difference remains.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              psergey Sergei Petrunia added a comment -

              Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests
              Ways to repeat:

              1. Make the dataset:
              ./sysbench --test=./tests/db/oltp.lua --oltp-table-size=10000000 \
              --db-driver=mysql --mysql-user=root --mysql-socket=/tmp/mysqld.sock \
              --mysql-table-engine=innodb prepare

              2. Prepare two trees,
              1. "Before" tree: 5.3 branched at -r2954
              2. "After" tree: 5.3, branched at -r2955, with 3406

              Run the attached script and watch the difference in output:

              "Before" tree produces (showing only lines with 'OUT'):

              incr OUT
              13 OUT
              incr OUT
              12 OUT
              incr OUT
              12 OUT
              incr OUT
              12 OUT
              incr OUT
              12 OUT

              "After" tree produces (showing only lines with 'OUT'):
              incr OUT
              14 OUT
              incr OUT
              13 OUT
              incr OUT
              13 OUT
              incr OUT
              13 OUT
              incr OUT
              13 OUT

              Show
              psergey Sergei Petrunia added a comment - Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests Ways to repeat: 1. Make the dataset: ./sysbench --test=./tests/db/oltp.lua --oltp-table-size=10000000 \ --db-driver=mysql --mysql-user=root --mysql-socket=/tmp/mysqld.sock \ --mysql-table-engine=innodb prepare 2. Prepare two trees, 1. "Before" tree: 5.3 branched at -r2954 2. "After" tree: 5.3, branched at -r2955, with 3406 Run the attached script and watch the difference in output: "Before" tree produces (showing only lines with 'OUT'): incr OUT 13 OUT incr OUT 12 OUT incr OUT 12 OUT incr OUT 12 OUT incr OUT 12 OUT "After" tree produces (showing only lines with 'OUT'): incr OUT 14 OUT incr OUT 13 OUT incr OUT 13 OUT incr OUT 13 OUT incr OUT 13 OUT
              Hide
              psergey Sergei Petrunia added a comment -

              The script.

              • it is intended to be run from sql/ directory of a tree
              • modify to point to your my.cnf file, which should specify a datadir with pre-loaded sysbench data as specified in earlier comments.
                check-innodb-counters-here.sh
                LPexportBug929838_check-innodb-counters-here.sh
              Show
              psergey Sergei Petrunia added a comment - The script. it is intended to be run from sql/ directory of a tree modify to point to your my.cnf file, which should specify a datadir with pre-loaded sysbench data as specified in earlier comments. check-innodb-counters-here.sh LPexportBug929838_check-innodb-counters-here.sh
              Hide
              psergey Sergei Petrunia added a comment -

              Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests
              The script.

              • it is intended to be run from sql/ directory of a tree
              • modify to point to your my.cnf file, which should specify a datadir with pre-loaded sysbench data as specified in earlier comments.
              Show
              psergey Sergei Petrunia added a comment - Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests The script. it is intended to be run from sql/ directory of a tree modify to point to your my.cnf file, which should specify a datadir with pre-loaded sysbench data as specified in earlier comments.
              Hide
              psergey Sergei Petrunia added a comment -

              If you have trouble compiling the tree because of "warnings being treated as errors", here is a patch that shuts that off.
              werror-be-gone.diff
              LPexportBug929838_werror-be-gone.diff

              Show
              psergey Sergei Petrunia added a comment - If you have trouble compiling the tree because of "warnings being treated as errors", here is a patch that shuts that off. werror-be-gone.diff LPexportBug929838_werror-be-gone.diff
              Hide
              psergey Sergei Petrunia added a comment -

              Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests
              If you have trouble compiling the tree because of "warnings being treated as errors", here is a patch that shuts that off.

              Show
              psergey Sergei Petrunia added a comment - Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests If you have trouble compiling the tree because of "warnings being treated as errors", here is a patch that shuts that off.
              Hide
              psergey Sergei Petrunia added a comment -

              Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests
              The dataset is at:

              work.askmonty.org:/tmp/sysbench-data-10m.sql.bz2

              Show
              psergey Sergei Petrunia added a comment - Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests The dataset is at: work.askmonty.org:/tmp/sysbench-data-10m.sql.bz2
              Hide
              igor Igor Babaev added a comment -

              Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests
              We have a performance degradation for sysbench that was explained in Olav's Sandstaa patch for mysql-5.6. (see rev 3639.1.70 of lp:mysql-server/trunk )
              Olav dis not suggest any more or less general solution. He just prohibited using ICP for innodb primary clustered keys.

              Show
              igor Igor Babaev added a comment - Re: Downport of InnoDB/ICP from mysql 5.6 increased Innodb_buffer_pool_read_requests We have a performance degradation for sysbench that was explained in Olav's Sandstaa patch for mysql-5.6. (see rev 3639.1.70 of lp:mysql-server/trunk ) Olav dis not suggest any more or less general solution. He just prohibited using ICP for innodb primary clustered keys.
              Hide
              ratzpo Rasmus Johansson added a comment -

              Launchpad bug id: 929838

              Show
              ratzpo Rasmus Johansson added a comment - Launchpad bug id: 929838
              Hide
              psergey Sergei Petrunia added a comment -

              The problem doesn't seem to be introduced in MariaDB. It is innodb+xtradb changes. I'm still keeping this open, because I intend to investigate this and see if there are some redundant reads done as a result.

              Show
              psergey Sergei Petrunia added a comment - The problem doesn't seem to be introduced in MariaDB. It is innodb+xtradb changes. I'm still keeping this open, because I intend to investigate this and see if there are some redundant reads done as a result.

                People

                • Assignee:
                  psergey Sergei Petrunia
                  Reporter:
                  psergey Sergei Petrunia
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated: