Details
-
Type:
Task
-
Status: Open
-
Priority:
Minor
-
Resolution: Unresolved
-
Fix Version/s: 5.5
-
Component/s: None
-
Labels:
Description
The latest revision can be found on : https://github.com/jb-boin/mariadb/blob/5.5.30/debian/additions/mysqlreport
Read the comments to follow the new revisions additions (such as subquery cache, binary log cache, TokuDB stats, returned rows stats, threadpool usage stats and many small fixes/improvements).
—
I've made a patch for mysqlreport so it can report actual AriaDB page cache stats like the key buffer cache usage for MyISAM.
Patch is pretty trivial and based on how mysqlreport reports the MyISAM key cache informations.
I would strongly advise to verify if the returned values are correct and if possible, implement a better verification for the presence of AriaDB than checking the version string for "-MariaDB-".
Tested on MySQL 5.1 (no AriaDB infos shown) and on Maria 5.5.27 (shows informations without any error).
Here is an example of the produced output :
__ Aria Pagecache ______________________________________________________
Buffer used 124.95M of 128.00M %Used: 97.61
Current 128.00M %Usage: 100.00
Write hit 53.16%
Read hit 86.87%
ps: there is a warning when launching mysqlreport :
Use of uninitialized value in formline at mysqlreport line 1300
Its an upstream bug (same error encountered on Debian 6 with non MariaDB mysqlreport and MySQL 5.1) as mysqlreport reads "Innodb_buffer_pool_read_ahead_seq" value but it seems that this value has been replaced by "Innodb_buffer_pool_read_ahead" on MySQL/MariaDB for a long time, correcting this could also be a good idea.
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Threadpool usage calculation doesnt seems to be correct, i got these values on a live server (the threadpool was not full at the moment) :
__ Threads _____________________________________________________________
Running 1 of 1195
Created 365.79k 0.2/s
Slow 0 0/s
Threadpool 1301 of 1200 %Used: 108.42
Running 651 of 1200 %Running: 54.25
Idle 650 of 1200 %Idle: 54.17
------------------------------------------------+
| Variable_name | Value |
------------------------------------------------+
| Threadpool_idle_threads | 654 |
| Threadpool_threads | 656 |
| Threads_cached | 0 |
| Threads_connected | 1189 |
| Threads_created | 365790 |
| Threads_running | 418 |
------------------------------------------------+
Today's revision adds the XtraDB flushes LRU stats : https://github.com/jb-boin/mariadb/commit/a9922df1095d2b87d8541c1cce623df4b0f82656
Example of the output :
Flushes 49.65M 15.4/s
LRU 2.54M 0.8/s %Flush: 5.12
New revision :https://github.com/jb-boin/mariadb/commit/7598e45acb42b89a9de29600f46066350cf5494d#diff-7552e4de9944e68ad76cc2faaba80034
- MariaDB detection has been cleaned : was just checking that the Aria engine was enabled, now verify that the version string has -MariaDB on it
- Thread pool stats should now be shown on Percona Server as well
- The uptime format was "DAYS H:M:S", now "DAYS+H:M:S" for a better readability
- %Flush is now shown as %LRU to be consistent with the other stats output
- Deletion of the temporary file is now done with the Perl "unlink" function instead of executing the system "rm" or "del" command
This new revision (3.5-maria15 : https://github.com/jb-boin/mariadb/commit/a612dac0f4e3c7db358db10f740ca0cfd3b5121f) adds support for MariaDB 10.0 :
- TokuDB variables case changed from 5.5 to 10.0 (eg. Tokudb_CACHETABLE_SIZE_CURRENT => Tokudb_cachetable_size_current) : the $stats array indexes are now forced to have the first char uppercase and the rest lowercase to avoid issues when this kind of changes happens and to keep compat with both versions.
- (upstream bug) Test to show is the slow query log is enabled was relying on the log_slow_queries deprecated variable that has been replaced by slow_query_log for versions >= 5.1.29 and removed on MariaDB 10.0.
Tested without any errors/warnings issued on MySQL 5.1.72, MariaDB 5.5.40 and MariaDB 10.0.14 with TokuDB and tested both with XtraDB and Innodb plugin.
New revision (3.5-maria16 : https://github.com/jb-boin/mariadb/commit/bbd68f13b1cf90279e4713fc163bafc787df32ff) :
- The query cache section is not shown anymore when have_query_cache=ON, query_cache_size>0 and query_cache_type=OFF.
This is an updated version of the patch which now verify that the ariadb engine is present and active rather than checking that the server version string contains
MariaDB.The "Innodb_buffer_pool_read_ahead value isnt shown anymore to avoid the warning (variable was removed on innodb plugin on 5.1 and not present on 5.5).
Submitting this patch "upstream" could also be a good idea.