Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-571

merge 10.0-base and 10.0-monty

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Blocker
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 10.0.0
        • Component/s: None
        • Labels:
          None

          Description

          merge 10.0-base and 10.0-monty

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                timour Timour Katchaounov added a comment -

                One possible fix for the test failure in main.partition_myisam is:
                === modified file 'strings/my_vsnprintf.c'
                — strings/my_vsnprintf.c 2012-10-03 22:37:58 +0000
                +++ strings/my_vsnprintf.c 2012-10-23 09:59:12 +0000
                @@ -676,7 +676,7 @@ size_t my_vsnprintf_ex(CHARSET_INFO *cs,
                *to++= ' ';
                *to++= '"';
                my_strerror(errmsg_buff, sizeof(errmsg_buff), larg);

                • to= process_str_arg(cs, to, end, width-3, errmsg_buff, print_type);
                  + to= process_str_arg(cs, to, end-1, width-3, errmsg_buff, print_type);
                  *to++= '"';
                  }
                  continue;

                The fix passes all tests, but I am not completely sure if this is the right way to fix the problem.

                Show
                timour Timour Katchaounov added a comment - One possible fix for the test failure in main.partition_myisam is: === modified file 'strings/my_vsnprintf.c' — strings/my_vsnprintf.c 2012-10-03 22:37:58 +0000 +++ strings/my_vsnprintf.c 2012-10-23 09:59:12 +0000 @@ -676,7 +676,7 @@ size_t my_vsnprintf_ex(CHARSET_INFO *cs, *to++= ' '; *to++= '"'; my_strerror(errmsg_buff, sizeof(errmsg_buff), larg); to= process_str_arg(cs, to, end, width-3, errmsg_buff, print_type); + to= process_str_arg(cs, to, end-1, width-3, errmsg_buff, print_type); *to++= '"'; } continue; The fix passes all tests, but I am not completely sure if this is the right way to fix the problem.
                Hide
                Permalink
                serg Sergei Golubchik added a comment -

                done

                Show
                serg Sergei Golubchik added a comment - done

                  People

                  • Assignee:
                    serg Sergei Golubchik
                    Reporter:
                    serg Sergei Golubchik
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0 minutes
                      0m
                      Logged:
                      Time Spent - 2 days
                      2d