Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 10.0.8
-
Fix Version/s: 10.0.9
-
Component/s: None
-
Labels:None
Description
Under terms of MDEV-5304 we upgraded PCRE to 8.34
but did not add a CMake options to compile against an
external PCRE library.
We should eventually add a CMake option.
The problem is that using an external PCRE is dangerous
because of a possible stack overrun, which we fix in the bundled
PCRE with the patch pcre/maria-patches/pcre_stack_guard.diff.
There are some options:
a. wait for the PCRE team to add some built-in means to watch the stack
b. use the current PCRE version and check the pattern against
nested parenthesis every time we call pcre_compile().
Gliffy Diagrams
Attachments
Issue Links
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
I suppose now we can allow system PCRE if it supports pcre_stack_guard (cmake can check for it). When official PCRE will have a solution for this stack overflow we can extend the CMakeLists.txt to check for this solution too.
PCRE upstream accepted the stack guard patch with some small changes. This patch has been added to the mageia cauldron packages.
Here's the upstream one: "svn diff -r\1453:1454 svn://vcs.exim.org/pcre/code/trunk"
(had to escape the first revision, weird...)
Our PCRE stack_guard patch is now in Mageia.