Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5613

m_string.h exports generic function names without a namespace prefix, like str2int

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 5.5.35
        • Fix Version/s: 5.5.36
        • Component/s: None
        • Labels:
          None

          Description

          MariaDB's m_string.h exports generic function names without a namespace prefix, like str2int, which leads to collisions with other project's internal functions. See for example the Gentoo/Linux bugreport for a problem with GLPK.

          See Also: https://bugs.gentoo.org/show_bug.cgi?id=420095

            Gliffy Diagrams

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                devurandom Dennis Schridde added a comment -

                I also reported this issue against GLPK: http://lists.gnu.org/archive/html/bug-glpk/2014-02/msg00001.html

                Andrew Makhorin correctly points out that MariaDB "should keep the namespace clean".

                Show
                devurandom Dennis Schridde added a comment - I also reported this issue against GLPK: http://lists.gnu.org/archive/html/bug-glpk/2014-02/msg00001.html Andrew Makhorin correctly points out that MariaDB "should keep the namespace clean".
                Hide
                Permalink
                serg Sergei Golubchik added a comment -

                This happens, because my_sys.h includes my_valgrind.h, which includes m_string.h.

                Actually, an application isn't supposed to include my_sys.h, but m_string.h is particularly bad (or, should I say good? ) in polluting namespaces, so it's better to avoid it.

                I suppose we can easily fix this by not including m_string.h in my_valgrdind.h

                Show
                serg Sergei Golubchik added a comment - This happens, because my_sys.h includes my_valgrind.h , which includes m_string.h . Actually, an application isn't supposed to include my_sys.h , but m_string.h is particularly bad (or, should I say good? ) in polluting namespaces, so it's better to avoid it. I suppose we can easily fix this by not including m_string.h in my_valgrdind.h

                  People

                  • Assignee:
                    serg Sergei Golubchik
                    Reporter:
                    devurandom Dennis Schridde
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: