Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5483

Make sure all files in MariaDB have proper license headers

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 5.1.67, 5.2.14, 5.3.12, 5.5.36, 10.0.10
    • Fix Version/s: 10.0, 5.5
    • Component/s: None
    • Labels:

      Description

      While packaging MariaDB for Debian I noticed that there are many source files that lack proper license headers. For the sake of clarity and machine parseability if would be good if all source files would have proper license headers.

      The output of "mariadb$ licensecheck --copyright -r . -c ." showing many files with license UNKNOWN is at http://labs.seravo.fi/~otto/mariadb-repo/mariadb-5.5.34-license-headers.txt

      Just to make is explicit: I didn't find any legal issues while looking at the licenses. Many folders have folder wide copyright files etc instead of per file headers, so from a legal perspective things are ok, this is just a markup issue.

        Gliffy Diagrams

          Activity

          Hide
          otto Otto Kekäläinen added a comment -

          Here is an example of what a good file license header would look like:

          Copyright (C) 2014  The MariaDB Foundation
          
          This program is free software: you can redistribute it and/or modify
          it under the terms of the GNU General Public License as published by
          the Free Software Foundation; version 2 of the License.
          
          This program is distributed in the hope that it will be useful,
          but WITHOUT ANY WARRANTY; without even the implied warranty of
          MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
          GNU General Public License for more details.
          
          You should have received a copy of the GNU General Public License
          along with this program.  If not, see <http://www.gnu.org/licenses/>
          

          Official guidlines are at https://www.gnu.org/licenses/gpl-howto.html

          Show
          otto Otto Kekäläinen added a comment - Here is an example of what a good file license header would look like: Copyright (C) 2014 The MariaDB Foundation This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; version 2 of the License. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/> Official guidlines are at https://www.gnu.org/licenses/gpl-howto.html
          Hide
          otto Otto Kekäläinen added a comment -

          This bug in Debian is somwhat related:
          mariadb-server-core-5.5: MariaDB lacks documentation of OpenSSL exception to GPL
          https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761911

          Show
          otto Otto Kekäläinen added a comment - This bug in Debian is somwhat related: mariadb-server-core-5.5: MariaDB lacks documentation of OpenSSL exception to GPL https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761911

            People

            • Assignee:
              holyfoot Alexey Botchkov
              Reporter:
              otto Otto Kekäläinen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: