Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5419

no audit events for warnings converted to errors in the strict mode

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 5.5.34
        • Fix Version/s: 5.5.35
        • Component/s: None
        • Labels:

          Description

          When an warnings is converted into an error because of the strict sql_mode, this conversion happens inside THD::raise_condition. And my_message_sql is not called, so no audit events are generated for this error.

          Possible fixes:

          • generate audit events from THD::raise_condition (then they won't be generated when thd == 0)
          • always invoke my_message_sql for every error
          • some other way to make sure that all error processing code is invoked for any error

            Gliffy Diagrams

              Attachments

                Issue Links

                relates to

                Bug - A problem which impairs or prevents the functions of the product. MDEV-4846 SQL_ERROR_LOG plugin doesn't log errors produced with SIGNAL

                • Major - Major loss of function.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  holyfoot Alexey Botchkov added a comment -

                  Proposed fix:
                  http://lists.askmonty.org/pipermail/commits/2013-December/005777.html

                  Also fixes the mentioned MDEV-4846.

                  Show
                  holyfoot Alexey Botchkov added a comment - Proposed fix: http://lists.askmonty.org/pipermail/commits/2013-December/005777.html Also fixes the mentioned MDEV-4846 .
                  Hide
                  Permalink
                  dbart Daniel Bartholomew added a comment -

                  http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/4028

                  Show
                  dbart Daniel Bartholomew added a comment - http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/4028
                  Hide
                  Permalink
                  dbart Daniel Bartholomew added a comment -

                  http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/4027

                  Show
                  dbart Daniel Bartholomew added a comment - http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/4027

                    People

                    • Assignee:
                      holyfoot Alexey Botchkov
                      Reporter:
                      serg Sergei Golubchik
                    • Votes:
                      1 Vote for this issue
                      Watchers:
                      5 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - Not Specified
                        Not Specified
                        Remaining:
                        Remaining Estimate - 0 minutes
                        0m
                        Logged:
                        Time Spent - 4 hours, 5 minutes
                        4h 5m