Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5413

kvm-fulltest2 fails on 5.3 because BUILD/compile-pentium-debug-max with -O2 does not work

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: None
        • Component/s: None
        • Labels:

          Description

          kvm-fulltest2 always fails on 5.3 tree at the compilation stage. It attempts to build the server as

          EXTRA_FLAGS="-O2 -Wuninitialized -DFORCE_INIT_OF_VARS" EXTRA_CONFIGS="--with-embedded-privilege-control" AM_EXTRA_MAKEFLAGS="VERBOSE=1" BUILD/compile-pentium-debug-max

          In buildbot it fails with 

          In file included from /usr/include/string.h:642:0,
                 from ../include/m_string.h:32,
                 from mysql_priv.h:47,
                 from multi_range_read.cc:1:
In function 'void* memset(void*, int, size_t)',
    inlined from 'void Lifo_buffer::set_buffer_space(uchar*, uchar*)' at sql_lifo_buffer.h:70:5,
    inlined from 'int DsMrr_impl::dsmrr_init(handler*, RANGE_SEQ_IF*, void*, uint, uint, HANDLER_BUFFER*)' at multi_range_read.cc:895:62:
/usr/include/i386-linux-gnu/bits/string3.h:82:32: error: call to '__warn_memset_zero_len' declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters [-Werror]
...
cc1plus: all warnings being treated as errors
make[3]: *** [multi_range_read.o] Error 1
make[3]: *** Waiting for unfinished jobs....

          http://buildbot.askmonty.org/buildbot/builders/kvm-fulltest2/builds/1524/steps/compile/logs/stdio

          On my machine it failed with 

          client.c: In function 'cli_mysql_real_connect':
client.c:2952:7: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
client.c:2952:7: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
cc1: all warnings being treated as errors
make[3]: *** [client.lo] Error 1
make[3]: *** Waiting for unfinished jobs....

          Either way, it never makes it through the build. I don't know if this build variant is important enough to fix it, but if not, I suggest to disable the test for 5.3 tree – it is 20 minutes per push which we do not need to waste.

          I can do it in buildbot, I just need confirmation that the build is not going to be fixed.

          Alternatively, we can remove "-O2" from the flags.

            Gliffy Diagrams

              Attachments

                Activity

                Hide
                Permalink
                elenst Elena Stepanova added a comment -

                Removed kvm-fulltest2 from the 'alltrees' scheduler, and created a separate scheduler for running it on 5.5+ branches.

                Show
                elenst Elena Stepanova added a comment - Removed kvm-fulltest2 from the 'alltrees' scheduler, and created a separate scheduler for running it on 5.5+ branches.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    elenst Elena Stepanova
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: