Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5403

Reduce usage of LOCK_open: tc_count

        Details

        • Type: Task
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Fix Version/s: 10.0.9
        • Component/s: None
        • Labels:
          None

          Description

          tc_release_table is critical section of table cache. Among other things, it checks if table cache threshold is reached and if so evicts to-be-released table. This is done by comparing tc_count with tc_size.

          tc_count can be atomic and checked beyond of LOCK_open. Besides it is last global variable protected by this lock.

          The cost is as following:

          • tc_add_table() assumed that there is nothing to evict if tc_count > tc_size and skipped expensive LRU lookup. This assumption will be broken and LRU lookup must be done if tc_count >= tc_size.

          A patch for this task hasn't been benchmarked yet.

            Gliffy Diagrams

              Attachments

                Issue Links

                relates to

                Bug - A problem which impairs or prevents the functions of the product. MDEV-5864 Reduce usage of LOCK_open: TABLE_SHARE::tdc.free_tables

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-4702 Reduce usage of LOCK_open

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-4956 Reduce usage of LOCK_open: TABLE_SHARE::tdc.used_tables

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-5388 Reduce usage of LOCK_open: unused_tables

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-5492 Reduce usage of LOCK_open: TABLE::in_use

                • Major - Major loss of function.
                • Closed

                Task - A task that needs to be done. MDEV-5597 Reduce usage of LOCK_open: LOCK_flush

                • Major - Major loss of function.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  svoj Sergey Vojtovich added a comment -

                  Sergei, please review patch for this task.

                  Show
                  svoj Sergey Vojtovich added a comment - Sergei, please review patch for this task.
                  Hide
                  Permalink
                  svoj Sergey Vojtovich added a comment -

                  Sergei, please review updated patch.

                  Show
                  svoj Sergey Vojtovich added a comment - Sergei, please review updated patch.
                  Hide
                  Permalink
                  svoj Sergey Vojtovich added a comment -

                  Pushed to 10.0.9, revno: 4003, revision-id: svoj@mariadb.org-20140213061937-dt9f6rx9n13trbv6

                  Show
                  svoj Sergey Vojtovich added a comment - Pushed to 10.0.9, revno: 4003, revision-id: svoj@mariadb.org-20140213061937-dt9f6rx9n13trbv6

                    People

                    • Assignee:
                      svoj Sergey Vojtovich
                      Reporter:
                      svoj Sergey Vojtovich
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      3 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - Not Specified
                        Not Specified
                        Remaining:
                        Remaining Estimate - 0 minutes
                        0m
                        Logged:
                        Time Spent - 1 hour, 15 minutes
                        1h 15m