Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5342

CLONE - Test suite test file_contents fails in Slackware Linux

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 10.0.6
    • Fix Version/s: 5.5.34
    • Component/s: None
    • Labels:
      None
    • Environment:
      Slackware Linux 14.1 + kernel 3.11.6

      Description

      The test fails because file_contents.test does not know where to look for INFO_SRC and INFO_BIN.

      The attached patch enables it to recognise a Slackware system. I tried not to break any other tests but it's been a while since I touched Perl

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              duncan_roe Duncan Roe added a comment -

              The patch needs to be applied at 10.0.6

              Show
              duncan_roe Duncan Roe added a comment - The patch needs to be applied at 10.0.6
              Hide
              svoj Sergey Vojtovich added a comment -

              Hi Duncan,

              why this clone? Didn't our fix for MDEV-5127 solve this problem?

              Show
              svoj Sergey Vojtovich added a comment - Hi Duncan, why this clone? Didn't our fix for MDEV-5127 solve this problem?
              Hide
              duncan_roe Duncan Roe added a comment -

              Not for 10.0.6 Beta that I just installed

              Show
              duncan_roe Duncan Roe added a comment - Not for 10.0.6 Beta that I just installed
              Hide
              svoj Sergey Vojtovich added a comment -

              From what I can see fix for MDEV-5127 first appeared in 10.0.5. The fix is the same as for 5.5.
              Did you test 5.5? Could you paste test diff and attach your file_contents.test?

              Show
              svoj Sergey Vojtovich added a comment - From what I can see fix for MDEV-5127 first appeared in 10.0.5. The fix is the same as for 5.5. Did you test 5.5? Could you paste test diff and attach your file_contents.test?
              Hide
              svoj Sergey Vojtovich added a comment -

              err... s/test diff/test failure output

              Show
              svoj Sergey Vojtovich added a comment - err... s/test diff/test failure output
              Hide
              duncan_roe Duncan Roe added a comment -

              Sorry my bad. I patched the file and patch didn't complain. But you modified my suggested patch more than I realised. I expect it works - will test it tomorrow after big test finishes (my first time testing a fixed one)

              Show
              duncan_roe Duncan Roe added a comment - Sorry my bad. I patched the file and patch didn't complain. But you modified my suggested patch more than I realised. I expect it works - will test it tomorrow after big test finishes (my first time testing a fixed one)
              Hide
              duncan_roe Duncan Roe added a comment -

              Re-tested with test file_contents.test as distributed - works fine.
              Please close this - sorry for the noise.

              Show
              duncan_roe Duncan Roe added a comment - Re-tested with test file_contents.test as distributed - works fine. Please close this - sorry for the noise.

                People

                • Assignee:
                  svoj Sergey Vojtovich
                  Reporter:
                  duncan_roe Duncan Roe
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: