Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5311

vio_end() is called twice by embedded server

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.5.33a, 10.0.6
    • Fix Version/s: 5.5.35, 10.0.7
    • Component/s: None
    • Labels:
      None

      Description

      vio_end() is called twice in this fragment in libmysql/libmysql.c in case of embedded server:

      void STDCALL mysql_server_end()
      {
        if (!mysql_client_init)
          return;
      
        mysql_client_plugin_deinit();
      
      #ifdef EMBEDDED_LIBRARY
        end_embedded_server();
      #endif
        finish_client_errs();
        vio_end();
      

      First time it's called from end_embedded_server() via clean_up().
      Second time it's called from mysql_server_end() directly.

      The problem does not show up in any ways with the standard
      yassl and openssl libraries, but it's reported that mysqltest_embedded
      hangs when linked against a custom built openssl library.
      See the comments in the end of MDEV-4890.

        Gliffy Diagrams

          Attachments

            Activity

            Show
            holyfoot Alexey Botchkov added a comment - Patch proposal: http://lists.askmonty.org/pipermail/commits/2013-November/005715.html Should also fix https://mariadb.atlassian.net/browse/MDEV-5321

              People

              • Assignee:
                holyfoot Alexey Botchkov
                Reporter:
                bar Alexander Barkov
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours
                  4h