Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5220

[PATCH] MariaDB 10.0.4 doesn't compile without perfschema

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.0.4
    • Fix Version/s: 10.0.6
    • Component/s: None
    • Labels:
      None

      Description

      Attempts to build MariaDB with -DWITH_PERFSCHEMA_STORAGE_ENGINE=OFF result in several compilation errors. And even after fixing them several tests don't pass.

      Attaching two patches: one fixes compilation errors and another one makes tests passing without perfschema.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            svoj Sergey Vojtovich added a comment -

            main.information_schema and main.information_schema_all_engines of 10.0 are not functional currently (require xtradb which is disabled). Result files doesn't seem to refer to performance_schema and suggested patches do not apply. Won't include fixes for these tests yet.

            Show
            svoj Sergey Vojtovich added a comment - main.information_schema and main.information_schema_all_engines of 10.0 are not functional currently (require xtradb which is disabled). Result files doesn't seem to refer to performance_schema and suggested patches do not apply. Won't include fixes for these tests yet.
            Hide
            pivanof Pavel Ivanov added a comment -

            Ah, sorry, in our tree this patch is on top of another patch which makes xtradb-only tests to be executed with InnoDB...
            You may skip thos changes if you want, though disregarding performance_schema-related entries in the result the changes to main.information_schema and main.information_schema_all_engines are still applicable...

            Show
            pivanof Pavel Ivanov added a comment - Ah, sorry, in our tree this patch is on top of another patch which makes xtradb-only tests to be executed with InnoDB... You may skip thos changes if you want, though disregarding performance_schema-related entries in the result the changes to main.information_schema and main.information_schema_all_engines are still applicable...
            Hide
            svoj Sergey Vojtovich added a comment -

            Pavel, thanks for your contribution! FWICS these test do not have pfs-related entries in 10.0 (and that's likely a problem as such).

            Show
            svoj Sergey Vojtovich added a comment - Pavel, thanks for your contribution! FWICS these test do not have pfs-related entries in 10.0 (and that's likely a problem as such).
            Hide
            svoj Sergey Vojtovich added a comment -

            Sergei, could you have a quick look at this patch?

            Show
            svoj Sergey Vojtovich added a comment - Sergei, could you have a quick look at this patch?
            Hide
            svoj Sergey Vojtovich added a comment -

            Fixed in 10.0.6, revision-id: svoj@mariadb.org-20131114140000-5eq8gopqu5giwvqq

            Show
            svoj Sergey Vojtovich added a comment - Fixed in 10.0.6, revision-id: svoj@mariadb.org-20131114140000-5eq8gopqu5giwvqq
            Hide
            pivanof Pavel Ivanov added a comment -

            Currently 10.0.8 doesn't compile without perfschema again (because of errors in xtradb). Should I open a new issue for this or this issue should be reopened?

            Show
            pivanof Pavel Ivanov added a comment - Currently 10.0.8 doesn't compile without perfschema again (because of errors in xtradb). Should I open a new issue for this or this issue should be reopened?
            Hide
            svoj Sergey Vojtovich added a comment -

            Hi Pavel, please open new issue.

            Show
            svoj Sergey Vojtovich added a comment - Hi Pavel, please open new issue.

              People

              • Assignee:
                svoj Sergey Vojtovich
                Reporter:
                pivanof Pavel Ivanov
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: