Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5139

Add "mtr --ps --embedded" run to BuildBot

        Details

        • Type: Task
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Fix Version/s: N/A
        • Component/s: Tests
        • Labels:
          None

          Description

          "mtr --ps --embedded" fails on about half of the tests.
          See MDEV-5138 for details. This problem sneaked in
          because non of the BuildBot machines run "mtr --ps --embedded".

          After MDEV-5138 gets fixed, we need to make sure that
          this problem does not happen again in the future.

          A "mtr --ps --embedded" run should be added to some BuildBot machines.

            Gliffy Diagrams

              Attachments

                Issue Links

                relates to

                Bug - A problem which impairs or prevents the functions of the product. MDEV-5138 Numerous test failures in "mtr --ps --embedded"

                • Major - Major loss of function.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  dbart Daniel Bartholomew added a comment - - edited

                  Would something like the following added around line 3364 of maria-master.cfg work? :

                  f.addStep(mtr_step("ps-embedded", "--ps --embedded",
                  "--ps --embedded"))

                  Show
                  dbart Daniel Bartholomew added a comment - - edited Would something like the following added around line 3364 of maria-master.cfg work? : f.addStep(mtr_step("ps-embedded", "--ps --embedded", "--ps --embedded"))
                  Hide
                  Permalink
                  bar Alexander Barkov added a comment -

                  Sorry, I don't know what maria-master.cfg is.

                  Show
                  bar Alexander Barkov added a comment - Sorry, I don't know what maria-master.cfg is.
                  Hide
                  Permalink
                  elenst Elena Stepanova added a comment -

                  As I understand, it's supposed to add this MTR combination to fulltest and fulltest2.
                  In this case, maybe it also makes sense to add --parallel=<something> ? And maybe --mem?

                  Show
                  elenst Elena Stepanova added a comment - As I understand, it's supposed to add this MTR combination to fulltest and fulltest2. In this case, maybe it also makes sense to add --parallel=<something> ? And maybe --mem?
                  Hide
                  Permalink
                  dbart Daniel Bartholomew added a comment -

                  elena: Yes. The idea is to add a test with that MTR combination. I can add those, assuming they're fine with bar.

                  bar: maria-master.cfg is the main buildbot config file.
                  All of the tests that buildbot runs are configured here. Are elena's additions OK with you?

                  Any other additions?

                  Thanks.

                  Show
                  dbart Daniel Bartholomew added a comment - elena: Yes. The idea is to add a test with that MTR combination. I can add those, assuming they're fine with bar. bar: maria-master.cfg is the main buildbot config file. All of the tests that buildbot runs are configured here. Are elena's additions OK with you? Any other additions? Thanks.
                  Hide
                  Permalink
                  bar Alexander Barkov added a comment -

                  adding --parallel=xxx and --mem sounds find for me. Thanks.

                  Show
                  bar Alexander Barkov added a comment - adding --parallel=xxx and --mem sounds find for me. Thanks.
                  Hide
                  Permalink
                  dbart Daniel Bartholomew added a comment -

                  I've added the following to maria-master.cfg :

                  f.addStep(mtr_step("ps-embedded", "--ps --embedded",
                  "--ps --embedded --mem --parallel=4"))

                  Anything more that needs to be done for this task?

                  Show
                  dbart Daniel Bartholomew added a comment - I've added the following to maria-master.cfg : f.addStep(mtr_step("ps-embedded", "--ps --embedded", "--ps --embedded --mem --parallel=4")) Anything more that needs to be done for this task?
                  Hide
                  Permalink
                  serg Sergei Golubchik added a comment -

                  Daniel Bartholomew, thanks!

                  Show
                  serg Sergei Golubchik added a comment - Daniel Bartholomew , thanks!

                    People

                    • Assignee:
                      dbart Daniel Bartholomew
                      Reporter:
                      bar Alexander Barkov
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      4 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: