Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5127

Test suite test file_contents fails in Slackware Linux

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: 5.5.33a
        • Fix Version/s: 5.5.34
        • Component/s: None
        • Labels:
          None
        • Environment:
          Slackware Linux 14.0 + kernel 3.10.4

          Description

          The test fails because file_contents.test does not know where to look for INFO_SRC and INFO_BIN.

          The attached patch enables it to recognise a Slackware system. I tried not to break any other tests but it's been a while since I touched Perl

            Gliffy Diagrams

              Attachments

                Issue Links

                is duplicated by

                Bug - A problem which impairs or prevents the functions of the product. MDEV-5342 CLONE - Test suite test file_contents fails in Slackware Linux

                • Minor - Minor loss of function, or other problem where easy workaround is present.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  duncan_roe Duncan Roe added a comment -

                  I uploaded a better patch that also works for mariadb-10.x. Simple diff:

                  diff -r1.2 -r1.3
                  14c14
                  < + $dir_docs = glob "$dir_bin/doc/mariadb-?.*";
                  —
                  > + $dir_docs = glob "$dir_bin/doc/mariadb-[0-9]*";

                  The reason for using glob at all was that when it was a mysql patch, there were other candidate directories like
                  mysql-connector-c++-1.1.3 etc.

                  Show
                  duncan_roe Duncan Roe added a comment - I uploaded a better patch that also works for mariadb-10.x. Simple diff: diff -r1.2 -r1.3 14c14 < + $dir_docs = glob "$dir_bin/doc/mariadb-?.*"; — > + $dir_docs = glob "$dir_bin/doc/mariadb- [0-9] *"; The reason for using glob at all was that when it was a mysql patch, there were other candidate directories like mysql-connector-c++-1.1.3 etc.
                  Hide
                  Permalink
                  svoj Sergey Vojtovich added a comment -

                  Fixed in 5.5.34, revision-id: svoj@mariadb.org-20131021122924-o9wgpxqcv74mhlrv

                  Show
                  svoj Sergey Vojtovich added a comment - Fixed in 5.5.34, revision-id: svoj@mariadb.org-20131021122924-o9wgpxqcv74mhlrv
                  Hide
                  Permalink
                  svoj Sergey Vojtovich added a comment -

                  Duncan, thanks for your contribution. I pushed slightly modified fix to 5.5.34.

                  Show
                  svoj Sergey Vojtovich added a comment - Duncan, thanks for your contribution. I pushed slightly modified fix to 5.5.34.

                    People

                    • Assignee:
                      svoj Sergey Vojtovich
                      Reporter:
                      duncan_roe Duncan Roe
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      3 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: